Closed Bug 1171226 Opened 8 years ago Closed 8 years ago

Reading heap snapshots is *really* slow

Categories

(DevTools :: Memory, defect)

Product:
DevTools
Component:
Memory
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(2 files, 2 obsolete files)

Screenshot of Instruments profile
620.60 KB, image/png
Details
Fix mozilla::devtools::UniqueStringHashPolicy::match for strings with the same prefix
2.94 KB, patch
jimb
: review+
Details | Diff | Splinter Review 
Almost all time spent de-duplicating type names when creating DeserializedNodes.
(In reply to Nick Fitzgerald [:fitzgen][:nf] from comment #1)
> Created attachment 8614964 [details] [diff] [review]
> WIP: Stop de-duplicating strings

Reading a heap snapshot of the full process is basically a perma-beachball without this patch. With this patch, it is only ~1500 ms.

There is something funky going on in the de-duping, resulting in quadratic behavior or some such, because it shouldn't take minutes long.

        Attachment #8614964 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8614994 [details] [diff] [review]
Fix mozilla::devtools::UniqueStringHashPolicy::match for strings with the same prefix

Note: I ensured that the new test fails without the change.

        Attachment #8614994 -
        Flags: review?(jimb)

    
  

        Attachment #8614994 -
        Flags: review?(jimb) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/26d5497b19e9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox41:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.