1171282 - Avoid some unnecessary |operator new| null-checks in layout/

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Nicholas Nethercote [inactive]]

AllocateByObjectID() is infallible. Therefore the |operator new| of nsFrameList,
nsLineBox and nsRuleNode are too, as is nsRuleNode::CreateRootNode().

The patch also removes a couple of comments duplicated in both .h and .cpp
files.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Avoid some unnecessary |operator new| null-checks in layout/

Comment 2

[Daniel Holbert [:dholbert]]

Did some brief hg archeology to be sure this stuff is really supposed to be infallible. Looks like it is, which is good. In particular:
  (1) bug 809533 made nsPresArena allocation infallible. (and nsIPresShell::AllocateByObjectID uses nsPresArena for allocation)
  (2) bug 899385 documented the fact that AllocateByObjectID is infallible (in mozilla-central changeset 627c3d68be29)

Setting dependency on those bugs.

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8614998 [details] [diff] [review]
Avoid some unnecessary |operator new| null-checks in layout/

Looks good. r=me

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9816ca93dcd9

Comment 5

[Nicholas Nethercote [inactive]]

Thank you for the fast and careful review.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9816ca93dcd9