1171304 - "###!!! ASSERTION: Recursive GetService!" error accessing @mozilla.org/addons/integration;1 service using xpcshell debugger in debug builds

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: Don't attempt to use the addons/integration service in xpcshell

+++ This bug was initially created as a clone of Bug #1140131 +++

In a debug build, attempting to run xpcshell tests with --jsdebugger fails.  Bug 1140131 solved part of the problem and this patch is to solve the rest.

The following attachment avoids using the service in xpcshell by assuming that Services.appinfo.ID being undefined means xpcshell. It solves the recursion problem for me, but the process then crashes - I've no reason to believe the crash is related to this, but I'm not going to find time to dig deeper yet, so I'm just getting this up for comment.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8615037 [details] [diff] [review]
Don't attempt to use the addons/integration service in xpcshell

Review of attachment 8615037 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I could live with that if it doesn't break anything (add-on debugging in particular).

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Don't attempt to use the addons/integration service in xpcshell

Rebased patch.

Thanks Mark for the patch, we should proceed with it!
I hit this assertion while working on bug 1113865.
I don't get why this assertion isn't hit today,
but this patch looks good.

Try run:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=6484dad5727f

Comment 3

[Alexandre Poirot [:ochameau]]

This exception happens as we are running onNewScript hook for addonManager.js.
It makes perfect sense to hit this exception, I just don't get why we haven't hit that before!

Comment 4

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/9003db0847784daaacde751b30ff5cabe3dcbf27
Bug 1171304 - Don't attempt to use the addons/integration service in xpcshell r=ochameau

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9003db084778