1171305 - Remove lots of now-unnecessary null-checks involving XPCMaps

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Nicholas Nethercote [inactive]]

Part 2 of bug 1050035 removed a bunch of unnecessary null checks relating to
XPCMaps. But that patch got backed out. So here are those bits again.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove lots of now-unnecessary null-checks involving XPCMaps

This version is better than the previous version -- it removes some checks in
XPCWrappedNativeScope.cpp that I missed last time.

More importantly, the previous patch incorrectly assumed that
JSObject2WrappedJSMap::new() was infallible and called
mWrappedJSMap->ShutdownMarker() without a null-check. This patch fixes that by
making it (and JSObject2JSObjectMap::new()) infallible via the NS_ABORT_OOM
calls.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c84800344a

Comment 3

[Nicholas Nethercote [inactive]]

Thank you for the fast review.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f8c84800344a