Closed Bug 1171323 Opened 4 years ago Closed 4 years ago

Remove PL_DHashFreeStringKey(), because it's dead

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

PL_DHashFreeStringKey() is unused. Let's remove it.
Attachment #8615069 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/7fef63d2e18c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
I had one use in comm-central :(  Maybe I can work around it?
(In reply to Kent James (:rkent) from comment #4)
> I had one use in comm-central :(  Maybe I can work around it?

The easiest fix would just be to copy this code into that file. The actual function is simple.
Well, and inline FreeStringKey.
(In reply to Andrew McCreight [:mccr8] from comment #5)
> (In reply to Kent James (:rkent) from comment #4)
> > I had one use in comm-central :(  Maybe I can work around it?
> 
> The easiest fix would just be to copy this code into that file. The actual
> function is simple.

Yes that's what I am doing. No sense supporting the original function when there is only one user who can easily do this locally.
(In reply to Kent James (:rkent) from comment #4)
> I had one use in comm-central :(  Maybe I can work around it?

Oh, sorry! I forgot to check comm-central :(  I really wish it wasn't a separate repo.
Yes we have already done the comm-central workaround, so everything is awesome again!
You need to log in before you can comment on or make changes to this bug.