1171324 - [Customizer] Poor app performance after closing Customizer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Customizer, defect, P1)

Description

[Justin D'Arcangelo [:justindarc]]

Once the Customizer has been opened and closed, the app performance remains sluggish. The app performance/responsiveness is somewhat expected to be diminished while the Customizer is open because of the additional resources required. However, performance should go back to normal after the Customizer is closed.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

Comment 2

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8616887 [details] [review]
pull-request (master)

There seems to be an issue with controller initialization which I highlighted on the PR. I could be wrong about it, so let's discuss. For now, I'm holding this back for that.

Comment 3

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8616887 [details] [review]
pull-request (master)

Ready for re-review.

Comment 4

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8616887 [details] [review]
pull-request (master)

Looks good. I would have slightly preferred if all of the controllers were put in the `window.__customizer__` object so that we could encapsulate all destruction logic at the global scope, but this approach works too.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/fxos/customizer/commit/91a97e018631272c9f9e95bd23dedc22a289ea9d