browser/components/shell/nsMacShellService.cpp:359:5 [-Wunreachable-code-break] 'break' will never be executed

RESOLVED FIXED in Firefox 41

Status

()

Firefox
Shell Integration
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8615179 [details] [diff] [review]
Wunreachble-code-break_nsMacShellService.patch

Fix -Wunreachable-code-break warnings in shell/nsMacShellService.cpp. These breaks are redundant because the code returns lf->Launch() just above.

browser/components/shell/nsMacShellService.cpp:359:5 [-Wunreachable-code-break] 'break' will never be executed
browser/components/shell/nsMacShellService.cpp:371:5 [-Wunreachable-code-break] 'break' will never be executed
Attachment #8615179 - Flags: review?(mak77)

Updated

3 years ago
Attachment #8615179 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/71fe4f0920dc
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
(Assignee)

Updated

3 years ago
Blocks: 1235717
You need to log in before you can comment on or make changes to this bug.