Closed Bug 1171393 Opened 5 years ago Closed 3 years ago

Remove requirement for TEMP dir write access for Windows NPAPI process sandbox

Categories

(Core :: Security: Process Sandboxing, defect, P3)

All
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: bobowen, Assigned: handyman)

References

Details

(Whiteboard: sbwn1)

Attachments

(1 file)

Write access to the Temp directory is currently needed for:
* temporary file used to turn off protected mode
* some tests write to the profile, which is in the user's temp directory

Once these are resolved I think we can get rid of TEMP directory write access (set up in PluginProcessParent.cpp).
Depends on: 1202988
Whiteboard: sbp1
Whiteboard: sbp1 → sbwn1
Priority: -- → P3
Jim says David is looking at this bug.
Assignee: nobody → davidp99
Attached patch bug1171393.patchSplinter Review
I don't know what tests were failing on 6/4/2015 but they no longer seem to be of any concern.  Something has changed in the build process that makes running those tests now a challenge.

The comment in the code mentions mochitests but, for completeness, this is a full test suite run with this patch:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dca71df8a781&selectedJob=26779007
Attachment #8787675 - Flags: review?(bobowen.code)
Comment on attachment 8787675 [details] [diff] [review]
bug1171393.patch

Review of attachment 8787675 [details] [diff] [review]:
-----------------------------------------------------------------

I just thought, that it could be that those tests were only debug ones and we added access to temp for debug builds for leak testing.

Either way looks like this can go now, which is great.
Attachment #8787675 - Flags: review?(bobowen.code) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22990bbee8a8
Remove sandbox write access to temp directory which was opened for tests. r=bobowen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/22990bbee8a8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.