1171408 - Move NetworkEventsHandler.getString into WebConsoleClient

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

NetworkEventsHandler.getString() is a helper that should be sharable by other modules, so let's move it into WebConsoleClient object.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1171408-1.patch

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=73a46c0a4b2d

Honza

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8615268 [details] [diff] [review]
bug1171408-1.patch

Review of attachment 8615268 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed.

::: toolkit/devtools/webconsole/client.js
@@ +8,5 @@
>  
>  const {Cc, Ci, Cu} = require("chrome");
>  const DevToolsUtils = require("devtools/toolkit/DevToolsUtils");
>  const EventEmitter = require("devtools/toolkit/event-emitter");
> +const promise = Cu.import("resource://gre/modules/Promise.jsm", {}).Promise;

We are trying to convert all imports to require() and the devtools loader already provides a require("promise") that can be used here.

@@ +627,5 @@
> +   * @return object Promise
> +   *         A promise that is resolved when the full string contents
> +   *         are available, or rejected if something goes wrong.
> +   */
> +  getString: function(aStringGrip) {

Since this is a new method and the file is already inconsistent, let's avoid using the deprecated "aFoo" style for arguments and use the simpler "foo".

@@ +644,5 @@
> +    let longStringClient = this.longString(aStringGrip);
> +
> +    longStringClient.substring(initial.length, length, aResponse => {
> +      if (aResponse.error) {
> +        Cu.reportError(aResponse.error + ": " + aResponse.message);

Since this is now in toolkit, better use DevToolsUtils.reportException(), like we do elsewhere in this file, so that other embeddings can work properly.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1171408-2.patch

All comments fixed.

Thanks for the review Panos!

Honza

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=06976b1005b4

Honza

Comment 5

[Ryan VanderMeulen [:RyanVM]]

In the future, please make sure your patch includes proper commit information when requesting checkin.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0859b5b72ea5

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #5)
> In the future, please make sure your patch includes proper commit
> information when requesting checkin.
Oops, forgot to remove try info.
Thanks for fixing!

Honza

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0859b5b72ea5