1171460 - ESLint: Reconfigure comma-dangle

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The current setting of:

"comma-dangle": 1,

warns for trailing commas in objects, etc.

But, I find these are helpful in most cases, so that when you add a new item below, you don't have to worry about the previous item.

Anyway, to me I don't think this style point matters too much: it's fine to have them, and fine to not have them.

Comment 1

[Patrick Brosset <:pbro>]

As discussed on IRC:

<pbro> jryans: I don't feel strongly at all about that rule, I don't think it's big deal if we are inconsistent on this, it doesn't hurt readability of the code, and can't be a runtime problem anyway. I disallowed it in the original version because we had 3 persons agree on that in the ehterpad

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: 0001-Bug-1171460-ESLint-Allow-trailing-commas.-r-pbrosset.patch

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8615348 [details] [diff] [review]
0001-Bug-1171460-ESLint-Allow-trailing-commas.-r-pbrosset.patch

Review of attachment 8615348 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/.eslintrc
@@ +31,5 @@
>      // start and end braces on the same line.
>      "brace-style": [2, "1tbs", {"allowSingleLine": false}],
>      // Require camel case names
>      "camelcase": 2,
> +    // Allow trailing commas.

Could you elaborate why we allow trailing commas in this comment? Mention that that they make it easy to add new items to lists, and that they don't hurt readability of the code, etc..

Comment 4

[Patrick Brosset <:pbro>]

I should add: I think these comments are very useful because they are basically our style-guide.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ec9aa7541e4a

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ec9aa7541e4a