Closed
Bug 1171474
Opened 9 years ago
Closed 9 years ago
And finally we can remove the old linter
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S14 (12june)
People
(Reporter: kgrandon, Assigned: kgrandon)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
We can finally kill this! Julien and Ricky - could you give this a review? Thanks!
Attachment #8615532 -
Flags: review?(rchien)
Attachment #8615532 -
Flags: review?(felash)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8615532 [details] [review] Githug pull request - remove gjslint Thanks you Kevin for killing old linter, patch seems good to me. I just leave a nit so please fix it before landing.
Attachment #8615532 -
Flags: review?(rchien) → review+
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8615532 [details] [review] Githug pull request - remove gjslint r=me with some nits, but before landing please investigate if we can remove the custom reporter. Otherwise please at least rename the reporter.
Attachment #8615532 -
Flags: review?(felash) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Landing for now, but in a follow-up we can look at removing the reporter, or just switching to eslint fully. https://github.com/mozilla-b2g/gaia/commit/74db46fe7d812f4f61c560918f53d288a7729cc7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•9 years ago
|
||
Follow-up landed to address nit: https://github.com/mozilla-b2g/gaia/commit/bea2b43b3859f84aa84e51b6ef771fe2a45aac12
|
||
Updated•9 years ago
|
Target Milestone: --- → 2.2 S14 (12june)
You need to log in
before you can comment on or make changes to this bug.
Description
•