Closed Bug 1171476 Opened 9 years ago Closed 9 years ago

selfserve-agent reinstalls buildapi on each puppet run

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: dustin)

Details

Attachments

(2 files)

Just noticed this while watching logs on a few masters:
Jun  4 05:08:49 buildbot-master72.bb.releng.usw2.mozilla.com puppet-agent[15097]: (/Stage[main]/Selfserve_agent::Install/Python::Virtualenv[/builds/selfserve-agent]/Python::Virtualenv::Package[/builds/selfserve-agent||buildapi==0.3.16]/Exec[pip /builds/selfserve-agent||buildapi==0.3.16]/returns) executed successfully
Jun  4 05:38:43 buildbot-master72.bb.releng.usw2.mozilla.com puppet-agent[17166]: (/Stage[main]/Selfserve_agent::Install/Python::Virtualenv[/builds/selfserve-agent]/Python::Virtualenv::Package[/builds/selfserve-agent||buildapi==0.3.16]/Exec[pip /builds/selfserve-agent||buildapi==0.3.16]/returns) executed successfully
Jun  4 06:08:45 buildbot-master72.bb.releng.usw2.mozilla.com puppet-agent[19074]: (/Stage[main]/Selfserve_agent::Install/Python::Virtualenv[/builds/selfserve-agent]/Python::Virtualenv::Package[/builds/selfserve-agent||buildapi==0.3.16]/Exec[pip /builds/selfserve-agent||buildapi==0.3.16]/returns) executed successfully
Jun  4 06:39:08 buildbot-master72.bb.releng.usw2.mozilla.com puppet-agent[20982]: (/Stage[main]/Selfserve_agent::Install/Python::Virtualenv[/builds/selfserve-agent]/Python::Virtualenv::Package[/builds/selfserve-agent||buildapi==0.3.16]/Exec[pip /builds/selfserve-agent||buildapi==0.3.16]/returns) executed successfully
Jun  4 07:08:51 buildbot-master72.bb.releng.usw2.mozilla.com puppet-agent[23100]: (/Stage[main]/Selfserve_agent::Install/Python::Virtualenv[/builds/selfserve-agent]/Python::Virtualenv::Package[/builds/selfserve-agent||buildapi==0.3.16]/Exec[pip /builds/selfserve-agent||buildapi==0.3.16]/returns) executed successfully
Jun  4 07:38:50 buildbot-master72.bb.releng.usw2.mozilla.com puppet-agent[25473]: (/Stage[main]/Selfserve_agent::Install/Python::Virtualenv[/builds/selfserve-agent]/Python::Virtualenv::Package[/builds/selfserve-agent||buildapi==0.3.16]/Exec[pip /builds/selfserve-agent||buildapi==0.3.16]/returns) executed successfully
[root@buildbot-master72.bb.releng.usw2.mozilla.com ~]# /builds/selfserve-agent/bin/python /tools/misc-python/pip-check.py buildapi==0.3.16
Traceback (most recent call last):
  File "/tools/misc-python/pip-check.py", line 20, in <module>
    dist = pkg_resources.working_set.find(req)
  File "/builds/selfserve-agent/lib/python2.7/site-packages/pkg_resources.py", line 442, in find
    raise VersionConflict(dist,req)     # XXX add more info
VersionConflict: (buildapi 0.3.16-r0 (/builds/selfserve-agent/lib/python2.7/site-packages), Requirement.parse('buildapi==0.3.16'))
not found - exit status 0
Assignee: nobody → dustin
[root@buildbot-master72.bb.releng.usw2.mozilla.com site-packages]# cat buildapi-0.3.16_r0-py2.7.egg-info/* | grep 0.3.16
Version: 0.3.16-r0

so it looks like whoever built the buildapi package uploaded something different than what's in the latest commit to the repo.  I think this has somethign to do with the tag-build thing - https://github.com/mozilla/build-buildapi/blob/master/setup.cfg#L2

https://wiki.mozilla.org/ReleaseEngineering/BuildAPI#BuildAPI says

* Comment out tag_build and tag_svn_revision in setup.cfg
  * This appends tarball name and revision (-R#), among other things

I'm not sure why those are in there at all.  Maybe we should just get rid of that whole section of setup.cfg.
Attached patch bug1171476.patchSplinter Review
Looks like you were the one to release 0.3.16 too :)

We'll be rid of all of this paster magic once buildapi moves to relengapi, so I think this is a safe enough fix for the moment.  Bumping to 0.3.17 means that we can revert easily if something goes horribly wrong.
Attachment #8615334 - Flags: review?(bhearsum)
Comment on attachment 8615334 [details] [diff] [review]
bug1171476.patch

Review of attachment 8615334 [details] [diff] [review]:
-----------------------------------------------------------------

Heh, figures :(. Thanks for fixing my mistake.
Attachment #8615334 - Flags: review?(bhearsum) → review+
Comment on attachment 8615334 [details] [diff] [review]
bug1171476.patch

0.3.17 uploaded to pypi.pub.b.m.o and to the puppetagain repos.
Attachment #8615334 - Flags: checked-in+
Bug 1171476: install the correctly-built buildapi; r=bhearsum
Attachment #8615354 - Flags: review?(bhearsum)
Comment on attachment 8615354 [details]
MozReview Request: Bug 1171476: install the correctly-built buildapi; r=bhearsum

https://reviewboard.mozilla.org/r/10243/#review8969

Ship It!
Attachment #8615354 - Flags: review?(bhearsum) → review+
Attachment #8615354 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.