1171566 - Make it easy to run Android JUnit 3 browser and background instrumentation tests locally

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Nick Alexander :nalexander [he/him]]

This ticket tracks making it easy to run the existing Android JUnit 3 instrumentation test suites (browser and background) locally.  This avoids a bunch of pain arranging for debug APKs to get to TBPL, and writing mozharness test runners.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1171566 - Part 1: Configure Gradle and Spoon. r?mcomella,liuche

Bug 1171566 - Part 1: Configure Gradle and Spoon. r?mcomella,liuche

There are few things happening here:

* A purely mechanical move of test sources into org.mozilla.test.browser.junit3.
  This is only to make it easy to specify the suite in Spoon.  (But it has the
  advantage of making it possible to move files around in IntelliJ, since the
  symlink points to src instead of org/mozilla/gecko.)

* Specifying the suite (package name) ended up requiring changes to the
  spoon-gradle-plugin anyway.  Hence, I've included this custom
  spoon-gradle-plugin version locally, while I work to upstream the changes.

* Some Gradle trickery to make |mach gradle runBrowserTests| execute Spoon with
  the correct package name.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1171566 - Part 2: Remove BrowserTestCase. r?mcomella,liuche

Bug 1171566 - Part 2: Remove BrowserTestCase. r?mcomella,liuche

This was just a remnant from earlier days.  This launched the Fennec
activity, which is absolutely *not* something we want to do during
these browser JUnit 3 tests.  That is, these should be pure
instrumentation tests that just run Java code in the correct package
and Java classloader context.  They shouldn't interact with the App
lifecycle at all.

Not all the tests pass; I took a shot at fixing one but don't care to
dig deeply right now.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8615504 [details]
MozReview Request: Bug 1171566 - Part 1: Configure Gradle and Spoon. r?mcomella,liuche

https://reviewboard.mozilla.org/r/10283/#review9073

Ship It!

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8615505 [details]
MozReview Request: Bug 1171566 - Part 2: Remove BrowserTestCase. r?mcomella,liuche

https://reviewboard.mozilla.org/r/10285/#review9077

Ship It!

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Given what I know and understand, lgtm - I think I'll have to do some research on Gradle syntax and layout before I really understand what's going on here though.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

And since I didn't know what Spoon was, https://github.com/square/spoon

Nice!

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

NI self to try this locally (oops!).

Comment 8

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/cba90cce9749
https://hg.mozilla.org/integration/fx-team/rev/5f1c8129cb76

Comment 9

[Nick Alexander :nalexander [he/him]]

Move fast and [try not to] break things!

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cba90cce9749
https://hg.mozilla.org/mozilla-central/rev/5f1c8129cb76

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Running locally wfm but I had to remove roboexample and fennec_mcomella.