Closed Bug 1171574 Opened 5 years ago Closed 5 years ago

Don't use LEADING_UNDERSCORE on iOS

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
Unspecified
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: ted, Assigned: ted)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

MozReview Request: bug 1171574 - XPCOMGlue doesn't need LEADING_UNDERSCORE for iOS apparently. r?froydnj
40 bytes, text/x-review-board-request
froydnj
: review+
Details 
I think this was mistakenly added in bug 852950.
bug 1171574 - XPCOMGlue doesn't need LEADING_UNDERSCORE for iOS apparently. r?froydnj
Attachment #8616048 - Flags: review?(nfroyd)
Comment on attachment 8616048 [details]
MozReview Request: bug 1171574 - XPCOMGlue doesn't need LEADING_UNDERSCORE for iOS apparently. r?froydnj

https://reviewboard.mozilla.org/r/10411/#review9119

Ship It!

::: xpcom/glue/standalone/nsXPCOMGlue.cpp:33
(Diff revision 1)
> -    defined(XP_DARWIN) || \
> +    defined(XP_MACOSX) || \

I am a little surprised that there is inconsistency here, but if the shoe fits...
Attachment #8616048 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/18389478f2fc
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.