Closed Bug 1171576 Opened 6 years ago Closed 6 years ago

In attachment-conversion script, preserve extra, non-MozReview flags

Categories

(bugzilla.mozilla.org Graveyard :: Extensions: MozReview Integration, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mcote, Unassigned)

Details

Attachments

(1 file)

It's possible that someone may have done a drive-by review (i.e. not been flagged for review in MozReview) of a MozReview attachment and set an r+ or r-.  This is especially likely in the earlier days, when flow was not clear and things were less stable.  We should preserve them by applying them to all children.
Also realized I was calling $child_attach->update() and $bug->add_comment() each time I added a flag, when it should be just once per attachment.
Attachment #8615522 - Flags: review?(glob)
Comment on attachment 8615522 [details] [diff] [review]
Preserve extra reviewers

Review of attachment 8615522 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob
Attachment #8615522 - Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   cf55aa5..6c5fcca  master -> master
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.