Closed
Bug 1171576
Opened 9 years ago
Closed 9 years ago
In attachment-conversion script, preserve extra, non-MozReview flags
Categories
(bugzilla.mozilla.org Graveyard :: Extensions: MozReview Integration, defect)
bugzilla.mozilla.org Graveyard
Extensions: MozReview Integration
Production
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcote, Unassigned)
Details
Attachments
(1 file)
4.96 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
It's possible that someone may have done a drive-by review (i.e. not been flagged for review in MozReview) of a MozReview attachment and set an r+ or r-. This is especially likely in the earlier days, when flow was not clear and things were less stable. We should preserve them by applying them to all children.
Assignee | ||
Comment 1•9 years ago
|
||
Also realized I was calling $child_attach->update() and $bug->add_comment() each time I added a flag, when it should be just once per attachment.
Attachment #8615522 -
Flags: review?(glob)
Comment on attachment 8615522 [details] [diff] [review] Preserve extra reviewers Review of attachment 8615522 [details] [diff] [review]: ----------------------------------------------------------------- r=glob
Attachment #8615522 -
Flags: review?(glob) → review+
Assignee | ||
Comment 3•9 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git cf55aa5..6c5fcca master -> master
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•