1171599 - Remote Tabs Home Panel needs a 'not logged in' state

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This bug is about displaying https://bug1144760.bugzilla.mozilla.org/attachment.cgi?id=8593086 on the Remote Tabs Home Panel when the user is not logged in.

Comment 2

[Richard Newman [:rnewman]]

N.B., there are three null states:

* Not logged in
* Logged in but can't sync
* Logged in but there are no other devices (synced successfully but no data)

Then there's the semi-success case:

* There are other devices, but they have no open tabs to show.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/563

This bug is about displaying https://bug1144760.bugzilla.mozilla.org/attachment.cgi?id=8593086 on the Remote Tabs Home Panel when the user is not logged in.

This patch actually also shows three addition states:

* When the sync of tabs failed
* When the sync was good but the user has no other devices with open tabs
* When the sync was good but the user has no other devices at all

It was easier to combine all these empty states in a single change.

To keep this code simple, I have implemented this with custom `UITableViewCell` instances.

Also, instead of doing a lot of conditional work in the UITableViewDataSource, like we do in `ClientPickerViewController`, I have chosen to instead make a few separate datasource/delegate subclasses that are swapped in and out depending on the state.

This keeps the main `RemoteTabsPanel` class relatively small and moves the logic for each state case into a much smaller and independent classes.

Comment 5

[Stephan Leroux [:sleroux]]

Comment on attachment 8616177 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/563

PR looks good - just some minor nitpicking comments. I really liked the error data source pattern + enum you used for the error states and custom error cells.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Fixed nits. Merged PR.

Comment 8

[Richard Newman [:rnewman]]

Added a follow-up to fix some of the non-localized wording:

d9965ad