Closed Bug 1171602 Opened 5 years ago Closed 5 years ago

Add mach command to run mochitest from a tests.zip

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

This will simply be a thin wrapper around the test harness. For now at least, it will be fairly naive. The only benefits it will be provide are:

* Discoverability/common interface (mach)
* Dependency set up (e.g mozbase)
* Defaults for things like utilityPath, certsPath, testingModulesDir and extraProfileFiles

It *will not* be super convenient like the in-tree mach command (at least for now). This means no test path resolving, no automatic flavor/subsuite detection, etc. Aside from the above benefits, it will be no different from running runtests.py directly.
Bug 1171602 - Run mochitest using mach from a tests.zip, r?chmanchester
Attachment #8615469 - Flags: review?(cmanchester)
Comment on attachment 8615469 [details]
MozReview Request: Bug 1171602 - Run mochitest using mach from a tests.zip, r?chmanchester

https://reviewboard.mozilla.org/r/10279/#review9069

::: testing/tools/mach_test_package_bootstrap.py:10
(Diff revision 1)
>  import time

'time' imported but unused

::: testing/mochitest/mach_test_package_commands.py:37
(Diff revision 1)
> +    @Command('mochitest', category='testing',
> +             description='Run the mochitest harness.',
> +             parser=setup_argument_parser)
> +    def mochitest(self, **kwargs):
> +        return run_mochitest(self.context, **kwargs)

We need at least positional arguments to make this usable. Can we just move the test_paths arg into MochitestArgumentParser?

I tried running this with --test-path and couldn't figure out what to give it (--manifest ran fine though).
Attachment #8615469 - Flags: review?(cmanchester)
Yeah it's pretty finicky. If you pass relative paths as if running from a srcdir it should work:
./mach mochitest --test-path dom/indexedDB

But agreed, moving test_paths into MochitestArgumentParser is a good idea.
Depends on: 1171971
Actually moving test_paths into the harness will be a fairly invasive change. I filed bug 1171971 to tackle it separately.
Comment on attachment 8615469 [details]
MozReview Request: Bug 1171602 - Run mochitest using mach from a tests.zip, r?chmanchester

https://reviewboard.mozilla.org/r/10279/#review9893

Being able to run mochitests from the test package is pretty excellent!
Attachment #8615469 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/43e3ece52f55
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.