Closed
Bug 1171631
Opened 9 years ago
Closed 9 years ago
Use mkdir -p in lib/freebl/Makefile to avoid errors in build logs
Categories
(NSS :: Build, defect)
NSS
Build
Tracking
(firefox41 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | affected |
People
(Reporter: ted, Assigned: ted)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
930 bytes,
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
This is fairly harmless in practice, but the way lib/freebl/Makefile creates a directory means it can wind up calling mkdir when the directory already exists: http://hg.mozilla.org/projects/nss/file/2d066157b71c/lib/freebl/Makefile#l562 It's already ignoring failure there (the leading -), but mkdir will print an error to the build log in this case. In my case I'm launching a build from inside XCode, and XCode parses that error out of the log as a build error, which is annoying. Using `mkdir -p` makes the error go away. This happens in practice because the Gecko build overrides SINGLE_SHLIB_DIR.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ted
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8615510 -
Flags: review?(kaie)
|
||
Updated•9 years ago
|
Attachment #8615510 -
Flags: review?(kaie) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/89e88a15d5b8d17613ce84425414679fe6011b35 bug 1171631 - Use mkdir -p in lib/freebl/Makefile to avoid errors in build logs. r=kaie
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•