Closed
Bug 1171642
Opened 9 years ago
Closed 9 years ago
Don't build skia arm assembly for iOS
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: ted, Assigned: ted)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Apple's assembler can't handle it.
|
Assignee | |
Comment 1•9 years ago
|
||
bug 1171642 - Disable some skia arm assembly for iOS. r?jrmuizel
Attachment #8616052 -
Flags: review?(jmuizelaar)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8616052 [details] MozReview Request: bug 1171642 - Disable some skia arm assembly for iOS. r?gw280 This file is autogenerated. Talk to gw280 for review.
Attachment #8616052 -
Flags: review?(jmuizelaar) → review-
|
|
Assignee | |
Comment 3•9 years ago
|
||
Oh hah, that was dumb. I should have just fixed it as part of bug 1170988.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8616052 -
Attachment description: MozReview Request: bug 1171642 - Disable some skia arm assembly for iOS. r?jrmuizel → MozReview Request: bug 1171642 - Disable some skia arm assembly for iOS. r?gw280
Attachment #8616052 -
Flags: review- → review?(gwright)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8616052 [details] MozReview Request: bug 1171642 - Disable some skia arm assembly for iOS. r?gw280 bug 1171642 - Disable some skia arm assembly for iOS. r?gw280
|
|
Assignee | |
Comment 5•9 years ago
|
||
I think I wrote the patch in bug 1170988 while building for the iOS simulator (x86), and then wrote this patch later while getting the device build working, then just forgot to fold them together.
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8616052 [details] MozReview Request: bug 1171642 - Disable some skia arm assembly for iOS. r?gw280 https://reviewboard.mozilla.org/r/10419/#review9815 Ship It!
Attachment #8616052 -
Flags: review?(gwright) → review+
|
|
||
Comment 7•9 years ago
|
||
We should let upstream know which files don't assemble with Apple's assembler though.
|
|
Assignee | |
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/273feb3f49ed
|
||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/273feb3f49ed
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•