1171735 - The tier 1 button should change visually depending on whether it's been pressed or not

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, defect, P3)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

When I click the "1" up in Treeherder's header, nothing seems to happen visually to the button. I know I've clicked it because "&filter-tier=1" appears in the URL (and goes away if I click it again), but the button itself doesn't change.

I see in this in the console whenever I click it:
15:40:20.380 Empty string passed to getElementById().1 index.min-4eb23b9d8f5991e15f4585078cf20ed7.js:2:0

(And it happens four times each time I click the button, apparently.)


Not sure if this is just on my end or if something is actually broken, though.

Comment 1

[Cameron Dawson [:camd]]

Wes: This only has an effect if there are [Tier-2] (or higher) jobs visible.  Here's an example:

https://treeherder.allizom.org/#/jobs?repo=mozilla-central&revision=90d9b7c391d3&filter-searchStr=os%20x

As you toggle that button, the [Tier-3] jobs show/hide accordingly.  So I think the feature is working just right.  But perhaps we need some kind of visual queue on the button itself.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The feature works just fine, but the button itself gives no indication of state. It just says "1" all the time.

"Show/hide excluded jobs" changes state when clicked. The new expand/collapse job groups button changes from + to - when clicked.

"Show/hide revision list" doesn't change appearance. Arguably it should do something.

Comment 3

[Phil Ringnalda (:philor)]

What is this "button" of which you speak?