Closed Bug 1171784 Opened 9 years ago Closed 4 years ago

Merge Firstrun overlay with Doorhanger overlay

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox41 affected)

RESOLVED INCOMPLETE
Tracking Status
firefox41 --- affected

People

(Reporter: liuche, Unassigned)

References

Details

(Whiteboard: [good next bug][lang=java])

Bug 1139553 adds a black overlay that is identical to the overlay for firstrun, so we should use the same one for both. On Gingerbread though, the doorhanger overlay is disabled for doorhangers, so I would opt to disable it for firstrun too (this will also improve perf for GB phones, which tend to be underpowered anyways).

This should cover naming cleanup to make the overlay less doorhanger-centric.

Basically, this should update the code at [1] to use the doorhanger overlay interface instead of a private method, and also strip out the xml layout objects that are currently being animated.

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/firstrun/FirstrunPane.java#62
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.