[Voting] When updating votestoconfirm to a new value, bugs with enough votes are not moved to CONFIRMED properly

ASSIGNED
Assigned to

Status

()

Bugzilla
Extensions
ASSIGNED
3 years ago
2 years ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
When an admin updates the votestoconfirm value and the new value is below votes on UNCONFIRMED bugs, they are not updated to CONFIRMED properly due to _confirm_if_vote_confirmed loading old product values in $bug->product_obj and not the new value for votestoconfirm. 

Patch coming up

dkl
(Assignee)

Comment 1

3 years ago
Created attachment 8615793 [details] [diff] [review]
1171813_1.patch

Also found by test_votes.t.
Assignee: extensions → dkl
Status: NEW → ASSIGNED
Attachment #8615793 - Flags: review?(LpSolit)
(Assignee)

Updated

3 years ago
Blocks: 1176368

Comment 2

2 years ago
I cannot reproduce this issue in master. In my testing, $bug->product_obj->{votestoconfirm} already contains the new value. Are you sure this problem isn't fixed by bug 1171811 already?

Comment 3

2 years ago
Comment on attachment 8615793 [details] [diff] [review]
1171813_1.patch

Cancelling review till comment 2 is answered.
Attachment #8615793 - Flags: review?(LpSolit)
You need to log in before you can comment on or make changes to this bug.