1171820 - Convert test_bug483440.html mochitest to an xpcshell test

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

Same deal as Bug 1167254 and Bug 1169195.

Comment 1

[:Cykesiopka]

Bug 1171557 adds some code I will take advantage of, so marking as a dep.

Comment 2

[:Cykesiopka]

Attachment: bug1171820_convert-test_bug483440.html-to-xpcshell_v1.patch

Comment 3

[:Cykesiopka]

Comment on attachment 8620838 [details] [diff] [review]
bug1171820_convert-test_bug483440.html-to-xpcshell_v1.patch

Review of attachment 8620838 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, didn't intend to use Splinter.

Comment 4

[:Cykesiopka]

Attachment: MozReview Request: Bug 1171820 - Convert test_bug483440.html mochitest to an xpcshell test.

Bug 1171820 - Convert test_bug483440.html mochitest to an xpcshell test.

Also includes minor partial cleanup of security/manager/ssl/tests/unit/xpcshell.ini.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8620840 [details]
MozReview Request: Bug 1171820 - Convert test_bug483440.html mochitest to an xpcshell test.

https://reviewboard.mozilla.org/r/10859/#review9553

Looks great, but see the comment about xpcshell.ini.

::: security/manager/ssl/tests/unit/xpcshell.ini:25
(Diff revision 1)
>  [test_datasignatureverifier.js]

If we're going to clean this file up, maybe we should sort the list of tests as well (otherwise, I'm not sure it's worth making these changes). I'm also inclined to say any changes of this sort should be in a different bug or at least a different commit.

Comment 6

[:Cykesiopka]

https://reviewboard.mozilla.org/r/10859/#review9597

> If we're going to clean this file up, maybe we should sort the list of tests as well (otherwise, I'm not sure it's worth making these changes). I'm also inclined to say any changes of this sort should be in a different bug or at least a different commit.

Sure. I've removed the clean up changes for now.

Comment 7

[:Cykesiopka]

Attachment: bug1171820_convert-test_bug483440.html-to-xpcshell_v2.patch

- Revert xpcshell.ini sorting changes
+ Switch test_certviewer_invalid_oids.js from CRLF (inherited from test_bug483440.html) to LF

Comment 8

[:Cykesiopka]

Thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ee7993e1f1b

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11c6bc8c844f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11c6bc8c844f