1171830 - Remove PL_DHashTableEnumerator use from nsDocLoader

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Nicholas Nethercote [inactive]]

PLDHashTable now has an iterator and a Clear() method, which lets us avoid some
PL_DHashTableEnumerate() calls in nsDocLoader.cpp.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove PL_DHashTableEnumerator use from nsDocLoader

One thing to note: the old ClearRequestInfoHash() function would clear all the
entries in the hash table but leave the entry storage in place. The new version
frees the entry storage; that's how PLDHashTable::Clear() works. This
difference will be noticeable if the code holds onto a pointer to a particular
element and then accesses it after ClearRequestInfoHash() is called. This would
be an odd thing to do and I can't see anything in the code like that, but I
thought I'd mention the possibility.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8615842 [details] [diff] [review]
Remove PL_DHashTableEnumerator use from nsDocLoader

Er, isn't this some odd reverse patch.

Comment 3

[Nicholas Nethercote [inactive]]

> Er, isn't this some odd reverse patch.

Yes it is. I have no idea how I managed to do that given that I'm using |hg mq| + |hg bzexport|. Anyway, let me try again.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: Remove PL_DHashTableEnumerator use from nsDocLoader

Comment 5

[Nicholas Nethercote [inactive]]

Thank you for the fast review :)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86293a07e4c3

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/86293a07e4c3