Closed Bug 1171849 Opened 5 years ago Closed 5 years ago
xpcshell-tests fail to run: Attribute
Error: 'module' object has no attribute 'formatter _option _defaults'
MozReview Request: Bug 1171849 - Let consumers override mozlog default formatter options, r?chmanchester
40 bytes, text/x-review-board-request
Starting this morning, I can no longer run xpcshell-tests locally, I get: $ ./mach xpcshell-test browser/components/loop/ From _tests: Kept 36132 existing; Added/updated 0; Removed 0 files and 0 directories. Error running mach: ['xpcshell-test', 'browser/components/loop/'] The error occurred in the implementation of the invoked mach command. This should never occur and is likely a bug in the implementation of that command. Consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: AttributeError: 'module' object has no attribute 'formatter_option_defaults' File "/Users/mark/loop/gecko-dev-dmose/testing/xpcshell/mach_commands.py", line 472, in run_xpcshell_test structured.commandline.formatter_option_defaults['verbose'] = True This happens regardless of if I supply a directory argument or not.
I've just confirmed, backing out bug 1171032 locally means I can run tests.
Bug 1171849 - Let consumers override mozlog default formatter options, r?chmanchester
Attachment #8615922 - Flags: review?(cmanchester)
Sorry about this, I didn't realize that xpcshell was poking at the dict I removed. Attached a patch that provides a more reasonable API for this use case.
Comment on attachment 8615922 [details] MozReview Request: Bug 1171849 - Let consumers override mozlog default formatter options, r?chmanchester https://reviewboard.mozilla.org/r/10379/#review9111 Sorry for not noticing this. Looks good to me.
Attachment #8615922 - Flags: review?(cmanchester) → review+
You need to log in before you can comment on or make changes to this bug.