1171860 - Tab Queue links do not always respect "External links in PB" pref

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Overlays, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Enable "Open multiple links" and "Open links in Private browsing" pref from Settings -> Customize -> 
2. Go to gmail app and tap on a link 
3. Choose to open with "Nightly" 
4. Wait a few seconds to put the link in the tab queue
5. Tap the "Nightly | 1 tab waiting" notification from the android notification bar

Expected results:
- The link should be opened in private browsing

Actual results:
- The link is opened in normal browsing. 

Note:
- if you choose "Open now" from the "Tab saved in Nightly | Open now" notification, the link is opened in private browsing.

Comment 1

[Teodora Vermesan (:TeoVermesan)]

Also, if you put two links in tab queue and the third open it now, then the third link is opened in private browsing and the two links queued are opened in normal browsing.

Comment 2

[Richard Newman [:rnewman]]

    @Override
    protected void openQueuedTabs() {
        ThreadUtils.assertNotOnUiThread();

        int queuedTabCount = TabQueueHelper.getTabQueueLength(BrowserApp.this);

        Telemetry.addToHistogram("FENNEC_TABQUEUE_QUEUESIZE", queuedTabCount);
        Telemetry.sendUIEvent(TelemetryContract.Event.LOAD_URL, TelemetryContract.Method.INTENT, "tabqueue-delayed");

        TabQueueHelper.openQueuedUrls(BrowserApp.this, mProfile, TabQueueHelper.FILE_NAME, false);  <<<<<<

        // If there's more than one tab then also show the tabs panel.
        if (queuedTabCount > 1) {
            ThreadUtils.postToUiThread(new Runnable() {
                @Override
                public void run() {
                    showNormalTabs();                  <<<<<<
                }
            });
        }
    }

Comment 3

[Youngsun Suh [:yssuh]]

Hi! I'd like to work on this bug, can someone assign it to me?

Comment 4

[:Margaret Leibovic]

You should coordinate with liuche to see what we're doing about bug 1205711.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1171860 - (Part 1) Tab Queue: Respect setting for opening external links in private browsing. r?mcomella

Bug 1171860 - (Part 1) Tab Queue: Respect setting for opening external links in private browsing. r?mcomella

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1171860 - (Part 2) Tab Queue: Show private tabs panel if tabs are opened there. r?mcomella

Bug 1171860 - (Part 2) Tab Queue: Show private tabs panel if tabs are opened there. r?mcomella

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to :Margaret Leibovic from comment #4)
> You should coordinate with liuche to see what we're doing about bug 1205711.

I just finished the patch before I saw your comment. I'll adapt the patch depending on bug 1205711.

Comment 8

[Chenxia Liu [:liuche]]

Bug 1205711 won't be in 44, so if you want to land this now, you could do that and I'll fix the fallout from changes to this bug.

If you're not in a hurry, we could wait and adapt this bug, but I'll also need to add UI to use a share-style-overlay for the "choose" state of private browsing from external links for that bug, so keep that in mind. Anthony and I are working through the copy/choices right now, and I'll get to that bug this week.

Comment 9

[:Margaret Leibovic]

(In reply to Chenxia Liu [:liuche] from comment #8)
> Bug 1205711 won't be in 44, so if you want to land this now, you could do
> that and I'll fix the fallout from changes to this bug.
> 
> If you're not in a hurry, we could wait and adapt this bug, but I'll also
> need to add UI to use a share-style-overlay for the "choose" state of
> private browsing from external links for that bug, so keep that in mind.
> Anthony and I are working through the copy/choices right now, and I'll get
> to that bug this week.

I don't think we need to worry about landing this bug... this only affects Nightly users who have both the "open links in pb" pref set (~1.5% of users) and use tab queues. Nobody has complained, so I assume this is about 0% of people.

That being said, we *will* need to think about what we should do if someone has both bug 1205711 and tab queues enabled.

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Moving this to v2 because there's currently no action to take here.

Comment 11

[:Margaret Leibovic]

I'm removing our current implementation in bug 1232467.