1171870 - |tools srcdir| throws even on success and crops path on messages

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

"tools srcdir /foobarbaz" displays an error in the console and the message that pops up says "/. does not exist [...]", cropping the actual path.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Don't throw when reloading devtools if it succeeds

Not sure how the lower-case s got there in the first place, but upper case S is what we commonly use.

Comment 2

[Joe Walker [:jwalker]]

Comment on attachment 8615894 [details] [diff] [review]
Don't throw when reloading devtools if it succeeds

Review of attachment 8615894 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm, the message really should come up when you throw, and that has the advantage of reporting a failure. Although the error status isn't actually used anywhere, so r+

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

What I changed from throw to return was actually the branch taken on successful srcdir lookup. Perhaps it used to throw in the opposite case in the past.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/85e876f34bcc

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/85e876f34bcc

Comment 6

[Francesco Lodolo [:flod]]

We need to rename these two strings: s and S are two different things when it comes to variables, and we want to be sure that all locales are updated.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Francesco Lodolo [:flod] from comment #6)
> We need to rename these two strings: s and S are two different things when
> it comes to variables, and we want to be sure that all locales are updated.

What are the two different meanings?  I think I've only seen "S" used before.

Comment 8

[Francesco Lodolo [:flod]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #7)
> What are the two different meanings?  I think I've only seen "S" used before.

That's beyond my understanding of the code, but things like bug 1133554 (and I guess this one) happen.
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/getFormattedString
http://aecreations.blogspot.it/2007/11/discovering-wonders-of.html

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Francesco Lodolo [:flod] from comment #8)
> (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #7)
> > What are the two different meanings?  I think I've only seen "S" used before.
> 
> That's beyond my understanding of the code, but things like bug 1133554 (and
> I guess this one) happen.
> https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/
> getFormattedString
> http://aecreations.blogspot.it/2007/11/discovering-wonders-of.html

Hmm, that led me down a terrifying rabbit hole... :)

Seems like a main difference is wide / unicode strings vs. C strings, which causes the string to terminate early if you use the wrong one.  Anyway, we'll want the correct "S" everywhere, so bumping the string ID seems needed.

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

Filed bug 1173301.