Closed Bug 1171870 Opened 7 years ago Closed 7 years ago

|tools srcdir| throws even on success and crops path on messages

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: past, Assigned: past)

References

Details

Attachments

(1 file)

"tools srcdir /foobarbaz" displays an error in the console and the message that pops up says "/. does not exist [...]", cropping the actual path.
Not sure how the lower-case s got there in the first place, but upper case S is what we commonly use.
Attachment #8615894 - Flags: review?(jwalker)
Comment on attachment 8615894 [details] [diff] [review]
Don't throw when reloading devtools if it succeeds

Review of attachment 8615894 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm, the message really should come up when you throw, and that has the advantage of reporting a failure. Although the error status isn't actually used anywhere, so r+
Attachment #8615894 - Flags: review?(jwalker) → review+
What I changed from throw to return was actually the branch taken on successful srcdir lookup. Perhaps it used to throw in the opposite case in the past.
https://hg.mozilla.org/mozilla-central/rev/85e876f34bcc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
We need to rename these two strings: s and S are two different things when it comes to variables, and we want to be sure that all locales are updated.
(In reply to Francesco Lodolo [:flod] from comment #6)
> We need to rename these two strings: s and S are two different things when
> it comes to variables, and we want to be sure that all locales are updated.

What are the two different meanings?  I think I've only seen "S" used before.
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #7)
> What are the two different meanings?  I think I've only seen "S" used before.

That's beyond my understanding of the code, but things like bug 1133554 (and I guess this one) happen.
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/getFormattedString
http://aecreations.blogspot.it/2007/11/discovering-wonders-of.html
(In reply to Francesco Lodolo [:flod] from comment #8)
> (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #7)
> > What are the two different meanings?  I think I've only seen "S" used before.
> 
> That's beyond my understanding of the code, but things like bug 1133554 (and
> I guess this one) happen.
> https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/
> getFormattedString
> http://aecreations.blogspot.it/2007/11/discovering-wonders-of.html

Hmm, that led me down a terrifying rabbit hole... :)

Seems like a main difference is wide / unicode strings vs. C strings, which causes the string to terminate early if you use the wrong one.  Anyway, we'll want the correct "S" everywhere, so bumping the string ID seems needed.
Filed bug 1173301.
Flags: needinfo?(past)
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.