1171941 - Test for redirect.sjs in fetch_tests.js is incorrect

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Josh Matthews [:jdm]]

The test succeeds because it checks for a 404 result, but the path it fetches (fetch/redirect.sjs) doesn't exist. It should still succeed if we get rid of the fetch/ prefix, when it should find the sjs file properly.

Comment 1

[Josh Matthews [:jdm]]

The test can be run via `./mach mochitest dom/workers/tests/serviceworkers/test_fetch_event.html` (run it with and without an --e10s argument, too)

Comment 2

[Anup Kumar [:reznord]]

Hi Josh,

I am interested in working on this bug, so, can you please assign this bug to me?

Thanks in advance,
Anup

Comment 3

[Anup Kumar [:reznord]]

Attachment: removed the prefix "fetch/" from fetch_tests.js in test for redirect.sjs

Removed the prefix "fetch/" from fetch_tests.js in test for redirect.sjs and tested as per what given in the comments.

Comment 4

[Josh Matthews [:jdm]]

Comment on attachment 8638547 [details] [diff] [review]
removed the prefix "fetch/" from fetch_tests.js in test for redirect.sjs

Review of attachment 8638547 [details] [diff] [review]:
-----------------------------------------------------------------

"Bug 1171941: reomved the fetch/ prefix."

This commit message should be a bit more descriptive (and fix the typo, please).

Comment 5

[Anup Kumar [:reznord]]

Attachment: Removed the prefix "fetch/" and fixed typo mistakes

Removed the prefix "fetch/" from fetch_tests.js in test for redirect.sjs and fixed the typo mistakes

Comment 6

[Anup Kumar [:reznord]]

Results of the tryServer
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7085851ff5e

Builds and Logs:
https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a7085851ff5e

Comment 7

[Josh Matthews [:jdm]]

Go ahead and add the checkin-needed keyword.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee746a325426

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ee746a325426

Comment 10

[Josh Matthews [:jdm]]

Comment on attachment 8638931 [details] [diff] [review]
Removed the prefix "fetch/" and fixed typo mistakes

Review of attachment 8638931 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Don't forget the "r=jdm" suffix on the commit message, too. No need to ask for re-review on this.