1171980 - Seamonkey: Replace draggesture with dragstart, dragdrop with drop events

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Neil Deakin]

In bug 1162050, we'd like to remove support for the draggesture and dragdrop events in favour of the standard dragstart and drop events. They should work the same, so it should be a search and replace.

In addition, I'd like to remove the old nsDragAndDrop.js library and instead convert to using the standard drag and drop api. This is a more significant amount of work, so Seamonkey could include the existing version in its own code in the meantime, so some shared location with Thunderbird.

Comment 1

[Philip Chee]

CC IanN

Comment 2

[Edmund Wong (:ewong)]

Attachment: proposed patch [SeaMonkey - p1] (v1)

Comment 3

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #2)
> Created attachment 8617823 [details] [diff] [review]
> proposed patch (v1)

without needing to read this patch,  I didn't touch nsDragAndDrop.js.  

I'm not exactly sure where I'd put it, but atm, I'm
contemplating mailnews/base/util

Comment 4

[[e-mail]]

Comment on attachment 8617823 [details] [diff] [review]
proposed patch [SeaMonkey - p1] (v1)

>     <listbox id="attachmentList" rows="3" seltype="multiple"
>-              onclick="attachmentListClick(event);" ondraggesture="nsDragAndDrop.startDrag(event,attachmentAreaDNDObserver);" ondragover="nsDragAndDrop.dragOver(event, attachmentAreaDNDObserver);" context="attachmentListContext"/>
>+              onclick="attachmentListClick(event);"
>+              ondragstart="nsDragAndDrop.startDrag(event,attachmentAreaDNDObserver);"
>+              ondragover="nsDragAndDrop.dragOver(event, attachmentAreaDNDObserver);"
>+              context="attachmentListContext"/>
Actually we don't use the dragover event here, you can just remove it.

Comment 5

[[e-mail]]

(In reply to Edmund Wong from comment #3)
> without needing to read this patch,  I didn't touch nsDragAndDrop.js.  
> 
> I'm not exactly sure where I'd put it, but atm, I'm
> contemplating mailnews/base/util

If Thunderbird wants to keep it, then mailnews/base/content would be a better fit.

There seem to be some unused references to nsDragAndDrop.js in editor and debugQA.

ChatZilla seems to use nsDragAndDrop.js too, they'll need their own bug if they don't have one already.

Comment 6

[Philip Chee]

Comment on attachment 8617823 [details] [diff] [review]
proposed patch [SeaMonkey - p1] (v1)

a=me for CLOSED TREE SeaMonkey

Comment 7

[Edmund Wong (:ewong)]

Attachment: checkin-patch (+ some space nits) [SeaMonkey - p1]

Comment 8

[Edmund Wong (:ewong)]

Comment on attachment 8622268 [details] [diff] [review]
checkin-patch (+ some space nits) [SeaMonkey - p1]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/c6edd15b2734

Comment 9

[Neil Deakin]

Is this now fixed?

Comment 10

[Philip Chee]

(In reply to Neil Deakin from comment #9)
> Is this now fixed?
It will be fixed when Bug 1174601[1] is fixed 

[1] Copy nsDragAndDrop.js from toolkit to SeaMonkey because it will be removed in bug 1162050