1171984 - Wrong result in a search-by-reviewer (possible summary parse error)

Status: RESOLVED DUPLICATE of bug 1221999

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

While looking at the list of patches reviewed by "me" [0] (so litterally "r=me"), I've noticed that b0a0287517d2 was in this list, although it doesn't contain a=me or r=me in the short changeset log. There is a "r=me" somewhere in the long description of this changeset, but way later. I guess this could affect other cases, where we have the B2G Bumper Bot commits changesets of other people. Is it intentional?

[0] https://hg.mozilla.org/integration/mozilla-inbound/log?rev=reviewer%28me%29&revcount=50

Comment 1

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/b0a0287517d2 does in fact list "me" as a reviewer.

So the question is: is looking at all lines for reviewer syntax a feature or a bug?

Comment 2

[Dan Minor [:dminor]]

(In reply to Gregory Szorc [:gps] from comment #1)
> https://hg.mozilla.org/mozilla-central/rev/b0a0287517d2 does in fact list
> "me" as a reviewer.
> 
> So the question is: is looking at all lines for reviewer syntax a feature or
> a bug?
Good question, for the reviewer identification I was extracting the summary and passing just that to the parse_reviewers function. If we only want to look at summaries it might be better to have this function split the description into lines and just examine the first line rather than do this at every call site - I just noticed that my call to parse_requal_reviewers fails to do this.

Comment 3

[Gregory Szorc [:gps]]

Being addressed in bug 1221999.