1172016 - Firefox Add-On: Browser Button Quits Working In Tab after Pop-Up Window Is Dismissed

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Kent Brewster]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150525141253

Steps to reproduce:

Wrote a very small add-on that pops a JavaScript alert if its browser button is clicked. Please see proof-of-concept page here: http://kentbrewster.com/ff-tab-bug/


Actual results:

Clicked a link on a site that opens a pop-up window and then closed the pop-up window. After that, the browser button stopped working until I focused on a different browser tab, no matter what location I was browsing in the original active tab.


Expected results:

The browser button should have continued to work.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Connor: can you take a look? I'm not as familiar with the new AddOn SDK as I used to be, but looks like an interesting bug with tab.attach()

Comment 2

[Marco Bonardo [:mak]]

I cannot reproduce the bug in Nightly, but I can reproduce in Aurora, so looks like something has been fixed in the meanwhile?
Would be good to figure out which bug fixed the issue, maybe you could try to find that using mozregression (https://mozilla.github.io/mozregression/)?
Clearly it would be sort of a reverse search, since it's not something that regressed, but rather something that got fixed.

Comment 3

[Marco Bonardo [:mak]]

Also because we should ensure to have a test covering that fix.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This was fixed in multiple ways apparently. My first attempts at bisecting the fix boiled down to e10s being enabled by default on nightly starting with the 2014-11-07 build. However, I was also able to reproduce this being fixed in release builds where e10s was not enabled between Fx39 and Fx40.

That fix range boils down to the Addon SDK update from bug 1160676.
https://hg.mozilla.org/integration/fx-team/rev/72f63499f285

I'll leave it to Dave to decide whether there's sufficient test coverage for this issue or not.