make strings on thank you page product-agnostic

RESOLVED FIXED

Status

Input Graveyard
Submission
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: willkg, Assigned: willkg)

Tracking

Details

(Whiteboard: u=user c=feedback p=2 s=input.2015q3)

(Assignee)

Description

3 years ago
edwin-after-1197952edwin-input
All the strings on the Thank You page that refer to a product have "Firefox" hard-coded.

This bug covers:

1. fixing the thank you page view to include the product in the context
2. creating new strings that are product-agnostic
3. make sure the new strings get translated
4. swap the old strings for the new strings
Grabbing this.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Landed in master: https://github.com/mozilla/fjord/commit/64937b512ac4c0768de5d3549e940c5d7c9de28d

Next step is to sync strings with verbatim and then wait for them to get translated.

Once they're translated we can move the strings around and ditch the old ones. Probably worth checking in 3 weeks.
I checked the localizations on postatus (https://postatus.herokuapp.com/p/Input/l10n_summary?app=feedback&highlight=es,pt_BR,po,hu,de,gr,fr,it,ru,ja,tr,zh_TW,zh_CN,el) and everything looks ok. However, I went to test fr and the strings aren't translated, yet.

I suspect there's a bug with the postatus checker or the script that's verifying things. Will look into that today.
I fixed the l10n_completion script to count fuzzy strings as untranslated. That should make things show up correctly in the postatus app.

I'll have to wait some more on this one.
Still waiting on es, fr, el and hu. If they're not done by next week, I'll write up bugs for them.
Whiteboard: u=user c=feedback p= s=input.2015q2 → u=user c=feedback p= s=input.2015q3
I wrote up bugs for the languages that still need translations. Making this bug block on them.
el still hasn't finished translating, but all the other locales have so I'm going to push this out now.

In a PR: https://github.com/mozilla/fjord/pull/624
This took about 2 points of work all told.
Whiteboard: u=user c=feedback p= s=input.2015q3 → u=user c=feedback p=2 s=input.2015q3
Pushed this to production just now. Marking as FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.