Make sure we never leave theme.selected with the manifest of an uninstalled app

RESOLVED FIXED

Status

Firefox OS
Gaia::Theme Editor
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: etienne, Assigned: etienne)

Tracking

(Blocks: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Otherwise all hell breaks loose.

Ideally the we would also add gecko hardening for this.
(Assignee)

Updated

3 years ago
Priority: -- → P1
(Assignee)

Comment 1

3 years ago
Created attachment 8616075 [details] [review]
Studio PR

This should help a lot and fix tons of potential bugs, please merge right away if it looks ok.
Assignee: nobody → etienne
Attachment #8616075 - Flags: review?(hub)
Comment on attachment 8616075 [details] [review]
Studio PR

lgtm.
Attachment #8616075 - Flags: review?(hub) → review+

Updated

3 years ago
Blocks: 1133768
(In reply to Etienne Segonzac (:etienne) from comment #0)
> Otherwise all hell breaks loose.
> 
> Ideally the we would also add gecko hardening for this.

Yeah we really need that to be done on the gecko side. Not that I don't trust gaia but... ;)
(Assignee)

Comment 4

3 years ago
https://github.com/fxos/studio/commit/b207df693ca65bbb005aafc9551b0f86fb06dc89

resolved on this side, we can file another bug for gecko
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Blocks: 1172040
You need to log in before you can comment on or make changes to this bug.