Closed
Bug 1172024
Opened 10 years ago
Closed 10 years ago
Make sure we never leave theme.selected with the manifest of an uninstalled app
Categories
(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: etienne, Assigned: etienne)
References
Details
Attachments
(1 file)
Otherwise all hell breaks loose.
Ideally the we would also add gecko hardening for this.
Assignee | ||
Updated•10 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•10 years ago
|
||
This should help a lot and fix tons of potential bugs, please merge right away if it looks ok.
Assignee: nobody → etienne
Attachment #8616075 -
Flags: review?(hub)
Comment 2•10 years ago
|
||
Comment on attachment 8616075 [details] [review]
Studio PR
lgtm.
Attachment #8616075 -
Flags: review?(hub) → review+
Updated•10 years ago
|
Blocks: spark-theme-editor
Comment 3•10 years ago
|
||
(In reply to Etienne Segonzac (:etienne) from comment #0)
> Otherwise all hell breaks loose.
>
> Ideally the we would also add gecko hardening for this.
Yeah we really need that to be done on the gecko side. Not that I don't trust gaia but... ;)
Assignee | ||
Comment 4•10 years ago
|
||
https://github.com/fxos/studio/commit/b207df693ca65bbb005aafc9551b0f86fb06dc89
resolved on this side, we can file another bug for gecko
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•