Closed Bug 1172024 Opened 4 years ago Closed 4 years ago

Make sure we never leave theme.selected with the manifest of an uninstalled app

Categories

(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: etienne, Assigned: etienne)

References

Details

Attachments

(1 file)

38 bytes, text/x-github-pull-request
hub
: review+
Details | Review
Otherwise all hell breaks loose.

Ideally the we would also add gecko hardening for this.
Priority: -- → P1
Attached file Studio PR
This should help a lot and fix tons of potential bugs, please merge right away if it looks ok.
Assignee: nobody → etienne
Attachment #8616075 - Flags: review?(hub)
Comment on attachment 8616075 [details] [review]
Studio PR

lgtm.
Attachment #8616075 - Flags: review?(hub) → review+
(In reply to Etienne Segonzac (:etienne) from comment #0)
> Otherwise all hell breaks loose.
> 
> Ideally the we would also add gecko hardening for this.

Yeah we really need that to be done on the gecko side. Not that I don't trust gaia but... ;)
https://github.com/fxos/studio/commit/b207df693ca65bbb005aafc9551b0f86fb06dc89

resolved on this side, we can file another bug for gecko
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Blocks: 1172040
You need to log in before you can comment on or make changes to this bug.