1172039 - Make the classification deletion icons more prominent

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

Ryan had difficulty this morning resolving the current trashcan icons for Annotation classification/bug deletion. They are a bit difficult to read at that size and luminance.

So I made a few tweaks to help make them a bit more prominent and their state more obvious.

I think our current fa-times-circle holds up a bit better at that size, and it is used elsewhere for 'destructive' actions like canceling jobs, so I propose using that.

We'll also then be using fa-times for 'queued' bug associations in the pinboard, and fa-times-circle for 'saved' bug associations in the annotations panel.

Comment 1

[Jonathan French (:jfrench)]

Attachment: PR612

Please see above PR for status and review.

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8616163 [details] [review]
PR612

lgtm!  :)

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f04b94270e0ca067a1d5e6c17e941f4ee1e2cf8d
Bug 1172039 - Make the classification deletion icons more prominent

Comment 4

[Jonathan French (:jfrench)]

Marking fixed per above merge. Will verify on the next push to stage/prod.

Comment 5

[Jonathan French (:jfrench)]

Verified fixed on stage.