Closed Bug 1172051 Opened 4 years ago Closed 4 years ago

[Theme Editor] Add Developer Mode prompt

Categories

(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: drs, Assigned: pdahiya)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1171596 +++

We should add a Developer Mode prompt to Theme Editor when it's first started.
Hi Eitenne

Attaching patch to display dev dialog prompt for studio app for devices with developer mode not enabled. Please review. Thanks!
Attachment #8617549 - Flags: review?(etienne)
Comment on attachment 8617549 [details] [review]
PR with fix of Bug 1172051

The code change looks perfectly fine, but I just want to double check:

Currently the prompt is showing even when developer mode is enabled, is this expected? Is there a separate bug?
Attachment #8617549 - Flags: review?(etienne) → review+
(In reply to Etienne Segonzac (:etienne) from comment #2)
> Comment on attachment 8617549 [details] [review]
> PR with fix of Bug 1172051
> 
> The code change looks perfectly fine, but I just want to double check:
> 
> Currently the prompt is showing even when developer mode is enabled, is this
> expected? Is there a separate bug?
When developer mode is enabled, the dev prompt should not be shown. I tested on my device and it doesn't show prompt for me when dev mode is enabled.

I am using below script to enable and disable dev mode.

adb shell "stop b2g"
adb shell "cd /data/b2g/mozilla/*.default/;echo 'user_pref(\"dom.apps.developer_mode\", true);' >> prefs.js;"
adb shell "start b2g"

Can you please try patch again and update bugs with STR if you still see this issue. Thanks!
(In reply to Etienne Segonzac (:etienne) from comment #2)
> Currently the prompt is showing even when developer mode is enabled, is this
> expected? Is there a separate bug?

DM might not actually be enabled for you. See https://developer.mozilla.org/en-US/Firefox_OS/Developer_Mode
(In reply to Punam Dahiya from comment #3)
> (In reply to Etienne Segonzac (:etienne) from comment #2)
> > Comment on attachment 8617549 [details] [review]
> > PR with fix of Bug 1172051
> > 
> > The code change looks perfectly fine, but I just want to double check:
> > 
> > Currently the prompt is showing even when developer mode is enabled, is this
> > expected? Is there a separate bug?
> When developer mode is enabled, the dev prompt should not be shown. I tested
> on my device and it doesn't show prompt for me when dev mode is enabled.
> 
> I am using below script to enable and disable dev mode.
> 
> adb shell "stop b2g"
> adb shell "cd /data/b2g/mozilla/*.default/;echo
> 'user_pref(\"dom.apps.developer_mode\", true);' >> prefs.js;"
> adb shell "start b2g"
> 
> Can you please try patch again and update bugs with STR if you still see
> this issue. Thanks!

Yep this works :)

Probably encountered bug 1170391 during my first try, since I switched it off at first to test the dialog, then enabled it from the phone.
https://github.com/fxos/studio/commit/abdddb04b7ae85ea3f9bcb46f211117afe84fe55
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.