1172083 - Link to "customize search providers" when user presses search label in quick search bar

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

As per bug 1172071

Sizing for the button's hit area is 48dp x 48dp.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I offered Anthony the alternative approach to have this search button run the default search - it gives users a clearer indication of what the search bar is supposed to do than jumping into settings (e.g. do all the buttons jump into settings?). We can try out Anthony's approach and see how it goes because it's better from a power user perspective.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

As a follow up to the visual hint, how hard would it be to link to this page in settings Sebastian?

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Anthony Lam (:antlam) from comment #2)
> As a follow up to the visual hint, how hard would it be to link to this page
> in settings Sebastian?

I'm not sure just yet. But it shouldn't be impossible. To be honest I wonder if this is something even power users need. Do power users actually change their search engines "all the time"? Nevertheless we can try it. If we decide to have the button do something else then we can always have this as an option on long press.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

This could be mentorable. The tricky part is making sure that this works with all different setting layouts.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The place to start here would be SearchEngineBar (which is where the magnifying glass icon is shown). GeckoPreferences is where our preference code starts and where you may be able to find the Search settings path.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

via IRC.

Comment 8

[Christian Schmitz (:tynn)]

Attachment: bug1172083.patch

Starting "preferences_search" with a click on the magnifying glass.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8674300 [details] [diff] [review]
bug1172083.patch

Review of attachment 8674300 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Works well!

However, the pressed state isn't shown when I click the label, as when I click other labels – can you look into adding that?

Comment 10

[Christian Schmitz (:tynn)]

Attachment: bug1172083.patch

Ohh, I didn't see any press state for the favicons, so I thought this was intentional. Added the background to the label as well.

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c38cbf257bac

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8674544 [details] [diff] [review]
bug1172083.patch

Review of attachment 8674544 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks Christian!

By the way, I filed bug 1215750 to add Telemetry to this button - it's waiting on Anthony to know if it's necessary. You could follow along, or even take the bug yourself! :)

Comment 13

[Christian Schmitz (:tynn)]

Android 4.3 API11+ opt M(rc4) failed after a retry. How can I rerun this test?

(In reply to Michael Comella (:mcomella) from comment #12)
> By the way, I filed bug 1215750 to add Telemetry to this button - it's
> waiting on Anthony to know if it's necessary. You could follow along, or
> even take the bug yourself! :)

I'd like to take the bug myself after this one is landed.

Comment 14

[:Margaret Leibovic]

(In reply to Christian Schmitz (:tynn) from comment #13)
> Android 4.3 API11+ opt M(rc4) failed after a retry. How can I rerun this
> test?

I believe you need special permissions for that. I just retriggered the job for you, but it looks like it's not your fault.

> (In reply to Michael Comella (:mcomella) from comment #12)
> > By the way, I filed bug 1215750 to add Telemetry to this button - it's
> > waiting on Anthony to know if it's necessary. You could follow along, or
> > even take the bug yourself! :)
> 
> I'd like to take the bug myself after this one is landed.

I'll assign you!

Comment 15

[Christian Schmitz (:tynn)]

Thank you Margaret.

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/688d6e1caaca

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/688d6e1caaca

Comment 18

[Teodora Vermesan (:TeoVermesan)]

Tested using:
Build: Firefox 44.0a1 (2015-10-27)
Device: Prestigio PSP5508 (Android 4.4.2)

Tapping the magnifying glass from the quick search bar opens the search submenu from settings.
But "Nightly" is displayed as a header: http://i.imgur.com/k6xF7H1.png
Is this expected?

Maybe it should be "Search". The same when you go to Menu -> Settings -> Customize -> Search:  http://i.imgur.com/AeM2Egc.png

Comment 19

[:Margaret Leibovic]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #18)
> Tested using:
> Build: Firefox 44.0a1 (2015-10-27)
> Device: Prestigio PSP5508 (Android 4.4.2)
> 
> Tapping the magnifying glass from the quick search bar opens the search
> submenu from settings.
> But "Nightly" is displayed as a header: http://i.imgur.com/k6xF7H1.png
> Is this expected?
> 
> Maybe it should be "Search". The same when you go to Menu -> Settings ->
> Customize -> Search:  http://i.imgur.com/AeM2Egc.png

I think we should file a new bug to address this. Christian, are you interested in filing a new bug and investigating this?

Comment 20

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I think it says "Nightly" because it returns to Fennec when you press it (hardware back or this back button). 

Though the label should say "<-- Search", the current UX flow is the desired one here. So let's be sure we're just updating the visual. :)

Comment 21

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Margaret, do we want a relnote for this?

Comment 22

[:Margaret Leibovic]

(In reply to Michael Comella (:mcomella) from comment #21)
> Margaret, do we want a relnote for this?

Sure, this could fit in well with the search history suggestions.

Comment 23

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Michael, Margaret, could you please provide suggested wording and blog/MDN links for this to be added to Beta44 release notes? Thanks.

Comment 24

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Ritu Kothari (:ritu) from comment #23)
> Michael, Margaret, could you please provide suggested wording and blog/MDN
> links for this to be added to Beta44 release notes? Thanks.

Spoke on irc – I think the title of this bug ("Link to "customize search providers" when user presses search label in quick search bar") seems appropriate.

Comment 25

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to Beta44 release notes.