Closed Bug 1172182 Opened 7 years ago Closed 7 years ago

Make a devtools/memory module

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

Pull out the memory logic from the memory actor, so it can be consumed by other actors that do not want to expose the actual actor itself.

This is mostly done for the memory actor (actors/utils/memory-bridge.js) but should be more consistent with the other performance actors being pulled out as well.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cb4948f8920
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8617668 - Flags: review?(vporof)
Attachment #8617668 - Flags: review?(vporof) → review+
Comment on attachment 8617668 [details] [diff] [review]
1172182-memoryactor.patch

Review of attachment 8617668 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/memory.js
@@ +28,5 @@
>   * An actor that returns memory usage data for its parent actor's window.
>   * A tab-scoped instance of this actor will measure the memory footprint of its
>   * parent tab. A global-scoped instance however, will measure the memory
>   * footprint of the chrome window referenced by the root actor.
> + * 

Nit: pls land a follow up for this trailing whitespace.
https://hg.mozilla.org/mozilla-central/rev/7bc47a30831f
https://hg.mozilla.org/mozilla-central/rev/ea7e872d6e4c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.