1172182 - Make a devtools/memory module

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Pull out the memory logic from the memory actor, so it can be consumed by other actors that do not want to expose the actual actor itself.

This is mostly done for the memory actor (actors/utils/memory-bridge.js) but should be more consistent with the other performance actors being pulled out as well.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1172182-memoryactor.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cb4948f8920

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

https://hg.mozilla.org/integration/fx-team/rev/7bc47a30831f

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ea7e872d6e4c

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8617668 [details] [diff] [review]
1172182-memoryactor.patch

Review of attachment 8617668 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/memory.js
@@ +28,5 @@
>   * An actor that returns memory usage data for its parent actor's window.
>   * A tab-scoped instance of this actor will measure the memory footprint of its
>   * parent tab. A global-scoped instance however, will measure the memory
>   * footprint of the chrome window referenced by the root actor.
> + * 

Nit: pls land a follow up for this trailing whitespace.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7bc47a30831f
https://hg.mozilla.org/mozilla-central/rev/ea7e872d6e4c