1172202 - checksetup.pl outputs a cpanfile whose stated requirements are more lax than those checksetup.pl later enforces

Status: RESOLVED INVALID

(bugzilla.mozilla.org :: General, defect)

Description

[Ed Morley [:emorley]]

Using BMO master:
1) ./checksetup.pl --cpanfile
2) cpanm --quiet --notest --installdeps --with-recommends --skip-satisfied \
     --with-all-features --without-feature oracle \
     --without-feature sqlite --without-feature pg .
3) ./checksetup.pl contrib/docker/checksetup_answers.txt

Results in:

***********************************************************************
* REQUIRED MODULES                                                    *
***********************************************************************
* Bugzilla requires you to install some Perl modules which are either *
* missing from your system, or the version on your system is too old. *
* See below for commands to install these modules.                    *
***********************************************************************
COMMANDS TO INSTALL REQUIRED MODULES (You *must* run all these commands
and then re-run checksetup.pl):

    /usr/bin/perl install-module.pl LWP::Protocol::https
    /usr/bin/perl install-module.pl Tie::IxHash
    /usr/bin/perl install-module.pl File::MimeInfo::Magic
    /usr/bin/perl install-module.pl Image::Magick
    /usr/bin/perl install-module.pl Regexp::Common
    /usr/bin/perl install-module.pl HTML::Tree
    /usr/bin/perl install-module.pl Crypt::CBC
    /usr/bin/perl install-module.pl Crypt::DES
    /usr/bin/perl install-module.pl Crypt::DES_EDE3
    /usr/bin/perl install-module.pl Crypt::OpenPGP
    /usr/bin/perl install-module.pl Crypt::SMIME
    /usr/bin/perl install-module.pl HTML::Tree
    /usr/bin/perl install-module.pl File::MimeInfo::Magic
    /usr/bin/perl install-module.pl IO::Scalar
*** Installation aborted. Read the messages above. ***

Now I could presumably remove the --skip-satisfied, however:
1) It reduces the time taken to install the deps considerably, since we don't try and install every single update available. Also some of the updates break since they need a whole load more os packages installed.
2) It's used by several of the docker configs, so presumably should work
3) Most importantly, I don't think it makes sense for the exported cpanfile to be less strict about the requirements than checksetup.pl is. ie: currently in cpanfile not all of the packages have minimum versions, so cpanm is happy with whatever is installed.

Could we fix the cpanfile export to include versions for the list of packages above? (Presuming they're all just out of date, rather than missing)

Comment 1

[Ed Morley [:emorley]]

The list of required modules above also contains dupes - would be good to sort it and de-dupe before printing.

Comment 2

[Ed Morley [:emorley]]

Ah ok - so I didn't realise that checksetup.pl dynamically scanned the extensions directory, rather than just using Requirements.pm (which makes sense, thinking about it). As such, this was just due to those files not being present at the time that command was run.

I've had to switch to another approach - since making the main CPAN install step depend on the extensions directory in the docker project, would mean having to repeat the cpan installs from scratch every time a file in the extensions directory changed.

I'll file another bug for de-duping the warning message in comment 0 however.