Last Comment Bug 1172237 - Automatically set up aliases when timezones have changed
: Automatically set up aliases when timezones have changed
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: Unspecified Unspecified
-- normal (vote)
: 4.3
Assigned To: Philipp Kewisch [:Fallen]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-06-06 03:51 PDT by Philipp Kewisch [:Fallen]
Modified: 2015-06-29 07:26 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix - v1 (15.18 KB, patch)
2015-06-06 03:53 PDT, Philipp Kewisch [:Fallen]
matthew.mecca: review+
Details | Diff | Splinter Review
update-zones.py with patch applied (9.10 KB, text/plain)
2015-06-06 03:53 PDT, Philipp Kewisch [:Fallen]
no flags Details

Description User image Philipp Kewisch [:Fallen] 2015-06-06 03:51:13 PDT
In 2015d, America/Montreal was aliased to America/Toronto. The information about that is in the "backward" file, so instead of just removing the zone we can add the alias.
Comment 1 User image Philipp Kewisch [:Fallen] 2015-06-06 03:53:15 PDT
Created attachment 8616368 [details] [diff] [review]
Fix - v1

I've also taken the liberty to turn the file into a class to avoid a few globals. Might be easier to apply the patch and review the whole file.
Comment 2 User image Philipp Kewisch [:Fallen] 2015-06-06 03:53:50 PDT
Created attachment 8616369 [details]
update-zones.py with patch applied
Comment 3 User image Matthew Mecca [:mmecca] 2015-06-06 11:07:26 PDT
Comment on attachment 8616368 [details] [diff] [review]
Fix - v1

Untested but looks reasonable
Comment 4 User image Philipp Kewisch [:Fallen] 2015-06-29 07:26:20 PDT
Pushed to comm-central changeset 47eaee3825ca

Note You need to log in before you can comment on or make changes to this bug.