Closed Bug 1172242 Opened 5 years ago Closed 5 years ago

Don't duplicate the communicator directory in TB

Categories

(Thunderbird :: Theme, defect)

All
Windows
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 41.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

As a preparation to remove the Aero tree in Windows theme I begin with the communicator directory to unify it.
Attached patch deDupCommunicator.patch (obsolete) — Splinter Review
Instead of using different smileys, I'm using the ones from OS X, because the aero smileys are too faint and I like the flat and more clear appearance of the OS X smileys more.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8616375 - Flags: review?(bwinton)
Comment on attachment 8616375 [details] [diff] [review]
deDupCommunicator.patch

Review of attachment 8616375 [details] [diff] [review]:
-----------------------------------------------------------------

I _think_ this is okay, but I do worry a little about the SeaMonkey folks…
So, r=me with the question below answered, and someone who knows how Suite is build saying it's good.  :)

::: mail/themes/windows/jar.mn
@@ -17,5 @@
>  # ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION!
>  # ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION!
>  
> -% skin communicator classic/1.0 %skin/classic/communicator/ os=WINNT osversion<6
> -% skin communicator classic/1.0 %skin/classic/communicator/ os!=WINNT

Don't we still need to specify something for os!=WINNT?
Could we just have:
  % skin communicator classic/1.0 %skin/classic/communicator/
?
Attachment #8616375 - Flags: review?(bwinton) → review+
(In reply to Blake Winton (:bwinton) from comment #2)
> Comment on attachment 8616375 [details] [diff] [review]
> deDupCommunicator.patch
> 
> Review of attachment 8616375 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I _think_ this is okay, but I do worry a little about the SeaMonkey folks…
> So, r=me with the question below answered, and someone who knows how Suite
> is build saying it's good.  :)
> 
> ::: mail/themes/windows/jar.mn
> @@ -17,5 @@
> >  # ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION!
> >  # ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION! ATTENTION!
> >  
> > -% skin communicator classic/1.0 %skin/classic/communicator/ os=WINNT osversion<6
> > -% skin communicator classic/1.0 %skin/classic/communicator/ os!=WINNT
> 
> Don't we still need to specify something for os!=WINNT?
> Could we just have:
>   % skin communicator classic/1.0 %skin/classic/communicator/
> ?

Yes, I removed the os=WINNT because it's no more needed.
Attachment #8616375 - Attachment is obsolete: true
Attachment #8622548 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/850e8b23e028 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
You need to log in before you can comment on or make changes to this bug.