Don't duplicate the newsblog directory in TB

RESOLVED FIXED in Thunderbird 41.0

Status

Thunderbird
Theme
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 41.0
All
Windows

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

2 years ago
Like bug 1172242 use only one newsblog directory. After this two bugs we have only the messenger directory in aero branch.
(Assignee)

Comment 1

2 years ago
Created attachment 8616377 [details] [diff] [review]
deDupNewsblog.patch

This patch needs to be applies after bug 1172242.

Like FX I'm renaming the XP image to -XP and remove the -aero from aero image.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8616377 - Flags: review?(bwinton)
(Assignee)

Comment 2

2 years ago
Created attachment 8620517 [details] [diff] [review]
deDupNewsblog.patch

Updated after landing of bug 1150627
Attachment #8616377 - Attachment is obsolete: true
Attachment #8616377 - Flags: review?(bwinton)
Attachment #8620517 - Flags: review?(bwinton)
Comment on attachment 8620517 [details] [diff] [review]
deDupNewsblog.patch

Review of attachment 8620517 [details] [diff] [review]:
-----------------------------------------------------------------

Other than the nit below, r=me!  Thanks!  :)

::: mail/themes/windows/jar.mn
@@ +274,5 @@
>    skin/classic/messenger/icons/arrow/foldercycler-arrow-right.png       (mail/icons/arrow/foldercycler-arrow-right.png)
>    skin/classic/messenger/icons/xp-pin-grey.png                (mail/icons/xp-pin-grey.png)
>    skin/classic/messenger/icons/xp-pin-red.png                 (mail/icons/xp-pin-red.png)
>    skin/classic/messenger/tagbg.png                            (mail/tagbg.png)
> +% skin messenger-newsblog classic/1.0 %skin/classic/messenger-newsblog/ os=WINNT

Like a previous patch, this seems to be removing the mapping for os!=WINNT, which I don't think we want.  Can it just be

% skin messenger-newsblog classic/1.0 %skin/classic/messenger-newsblog/

instead?
Attachment #8620517 - Flags: review?(bwinton) → review+
(Assignee)

Comment 4

2 years ago
Created attachment 8624313 [details] [diff] [review]
deDupNewsblog.patch

Fixed the review comment.

Carrying over the r+ from previous patch.
Attachment #8620517 - Attachment is obsolete: true
Attachment #8624313 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
https://hg.mozilla.org/comm-central/rev/6fb58ceea134

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
You need to log in before you can comment on or make changes to this bug.