I just ran the AMO addon validator on a test build and got this warning: ================================================== Potentially unsafe preference branch referenced Signing severity: low Warning: Changing network preferences may be dangerous, and often leads to performance costs. chrome/flagfox/content/flagfox.jsm 1328 // If "network.proxy.socks_remote_dns" is set to true or the proxy is otherwise set up to be the one to do all DNS resolution, then don't do ... 1329 if ( (proxyinfo != null) && (proxyinfo.flags & ================================================== Yeah... it's giving me a warning because I mentioned the existence of a network preference in a source comment. :/ Please do a little bit to reduce the false-positives this thing gets by not validating the comments. (at least the "//" single line comments, if multi line comments using "/*" & "*/" are hard to parse)
:kmag, how feasible do you think this is?
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.