1172405 - Build error when adding files to dom/workers and gfx/layers

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Bug 709490 add some files to dom/workers/ and gfx/layers/. After adding files I encounter build failed. The error log as following.

 0:05.37 /Users/Morris/mozilla/gecko-dev/gfx/layers/YCbCrImageDataSerializer.cpp:285:7: error: use of undeclared identifier 'NS_WARN_IF'
 0:05.37   if (NS_WARN_IF(!result)) {
 0:05.37       ^
 0:05.37 1 error generated.

 0:06.87 In file included from /Users/Morris/mozilla/gecko-dev/obj-x86_64-apple-darwin14.3.0/dom/workers/Unified_cpp_dom_workers1.cpp:2:
 0:06.87 /Users/Morris/mozilla/gecko-dev/dom/workers/ServiceWorkerContainer.cpp:100:8: error: use of undeclared identifier 'NS_NewURI'
 0:06.87   rv = NS_NewURI(getter_AddRefs(scriptURI), aScriptURL, nullptr,
 0:06.87        ^
 0:06.87 /Users/Morris/mozilla/gecko-dev/dom/workers/ServiceWorkerContainer.cpp:113:19: error: use of undeclared identifier 'NS_NewURI'
 0:06.87     nsresult rv = NS_NewURI(getter_AddRefs(scopeURI), NS_LITERAL_CSTRING("./"),
 0:06.87                   ^
 0:06.87 /Users/Morris/mozilla/gecko-dev/dom/workers/ServiceWorkerContainer.cpp:118:19: error: use of undeclared identifier 'NS_NewURI'
 0:06.87     nsresult rv = NS_NewURI(getter_AddRefs(scopeURI), aOptions.mScope.Value(),
 0:06.87                   ^
 0:06.87 3 errors generated.

This is because unified build group those files to another group so the error occurs. I'll upload a patch to fix this error.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Fix build error when adding files to dom/workers and gfx/layers.

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=661a86f9ed8d

Build only try should be ok.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/3b2f55f9839c

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3b2f55f9839c