1172407 - [Linux] Clicking the Performance settings button checks the first option and dismisses the menu

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Description

[Andrei Vaida [:avaida]]

Reproducible on:
* Aurora 40.0a2 (2015-06-04)
* Nightly 41.0a1 (2015-06-07)

Affected platforms:
Linux-only, tested with Ubuntu 14.04 (x64)

Steps to reproduce:
1. Launch Firefox.
2. Toggle the Developer Tools and select "Performance".
3. Click the settings button from the Performance toolbar.

Expected result:
Clicking the button once will bring up the settings menu.

Actual result:
* Clicking the button brings up the settings menu but also selects the first option available in it, "Show Gecko Platform Data".
* As the first option is selected, the menu is automatically dismissed, making it look like the menu itself is not working properly.

Notes:
* This issue might be a regression, I'll follow up with a regression range as soon as possible.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

This is a pretty bad one if we can't select options on linux. Any linux users want to check this out?

Comment 3

[Andrei Vaida [:avaida]]

This bug appears to be reproducible since that settings button was implemented in the first place, so I'm not really sure how reliable or relevant the following regression range is.

mozilla-central
===============
* Last good revision: af68c9c0e903
* First bad revision: 436686833af0
* Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=af68c9c0e903&tochange=436686833af0

mozilla-inbound
===============
* Last good revision: ada27d1eac50
* First bad revision: 3ef1e4e8a61e
* Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ada27d1eac50&tochange=3ef1e4e8a61e

Comment 4

[Wilhem Barbier [:nounoursheureux]]

Attachment: bug1172407_fix_performance_options_menu.patch

This patch should fix the popup menu :)

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8646255 [details] [diff] [review]
bug1172407_fix_performance_options_menu.patch

Review of attachment 8646255 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me on the change, r?ing Shu to test it out on Linux!

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8646255 [details] [diff] [review]
bug1172407_fix_performance_options_menu.patch

Review of attachment 8646255 [details] [diff] [review]:
-----------------------------------------------------------------

Seems it's not recreatable in other Linux, possibly something with the window manager in Ubuntu -- Andrei, can you confirm this patch fixes?

Comment 7

[Wilhem Barbier [:nounoursheureux]]

I'm running ArchLinux and my WM is Openbox. I had this bug and the patch fixed it.

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8646255 [details] [diff] [review]
bug1172407_fix_performance_options_menu.patch

Review of attachment 8646255 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good! Adding as checkin needed

Comment 9

[Jordan Santell [:jsantell] [@jsantell]]

Thanks, Wilhem!

Comment 10

[Wilhem Barbier [:nounoursheureux]]

Attachment: bug1161698_set_label_to_filename_when_importing.patch

Comment 11

[Wilhem Barbier [:nounoursheureux]]

Sorry I messed up and submitted a patch to the wrong issue ><

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3180877d4e44

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Landed the incorrect patch in https://hg.mozilla.org/integration/fx-team/rev/692b2fea4ef6
Backed it out in https://hg.mozilla.org/integration/fx-team/rev/b7cb976e52a6

Landed the correct patch in https://hg.mozilla.org/integration/fx-team/rev/3180877d4e44

Comment 14

[Wilhem Barbier [:nounoursheureux]]

Thanks :) . So that means the issue is resolved ?

Comment 15

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Wilhem Barbier [:schtroumps31] from comment #14)
> Thanks :) . So that means the issue is resolved ?

Sheriffs will resolve the bug once the patch is merged to mozilla-central, usually within a day.

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3180877d4e44

Comment 17

[Nazir Ahmed Sabbir [:NaSb]]

Successfully reproduce this bug in Nightly 41.0a1 (2015-06-07) (Build ID: 20150607030217) on Linux (Ubuntu 15.04) x64

This Bug is now verified as fixed on Latest Firefox Nightly 43.0a1 (2015-08-19)

Build ID: 20150819030206
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0