Rename Tagged to Sanitizer

RESOLVED FIXED in 2.2 S14 (12june)

Status

Firefox OS
Gaia::Shared
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: freddyb, Assigned: kgrandon)

Tracking

unspecified
2.2 S14 (12june)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Rename the file from tagged.js to sanitizer.js.
Rename the exposed object from Tagged to Sanitizer
and modify all files currently using it.
(Assignee)

Comment 1

3 years ago
I don't mind taking this, thanks for filing.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8617079 [details] [review]
[Gaia] Pull Request - Rename Tagged to Sanitizer
(Assignee)

Comment 3

3 years ago
Created attachment 8617084 [details] [review]
[Plugin] Pull Request - Rename Tagged to Sanitizer
(Assignee)

Updated

3 years ago
Attachment #8617079 - Attachment description: Pull Request - Rename Tagged to Sanitizer → [Gaia] Pull Request - Rename Tagged to Sanitizer
(Assignee)

Comment 4

3 years ago
Comment on attachment 8617079 [details] [review]
[Gaia] Pull Request - Rename Tagged to Sanitizer

Freddy - Any chance you would mind helping me give this rename a review?
Attachment #8617079 - Flags: review?(fbraun)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8617084 [details] [review]
[Plugin] Pull Request - Rename Tagged to Sanitizer

Freddy - would you mind helping me land this eslint plugin update? I guess we should also bump the npm version?
Attachment #8617084 - Flags: review?(fbraun)
(Reporter)

Comment 6

3 years ago
Comment on attachment 8617084 [details] [review]
[Plugin] Pull Request - Rename Tagged to Sanitizer

Merged!

I will create a new version of the plugin and publish to npm this morning.
Attachment #8617084 - Flags: review?(fbraun) → review+
(Reporter)

Comment 7

3 years ago
Comment on attachment 8617079 [details] [review]
[Gaia] Pull Request - Rename Tagged to Sanitizer

Thanks for taking this! Looks really good, but be reminded, that I can't give landing approval for modules I'm no peer of. :-)
Attachment #8617079 - Flags: review?(fbraun) → feedback+
(Reporter)

Comment 8

3 years ago
(In reply to Frederik Braun [:freddyb] from comment #6)
> I will create a new version of the plugin and publish to npm this morning.

Published as 0.1.5.
https://www.npmjs.com/package/eslint-plugin-no-unsafe-innerhtml
(Assignee)

Comment 9

3 years ago
Comment on attachment 8617079 [details] [review]
[Gaia] Pull Request - Rename Tagged to Sanitizer

Great, thanks for taking a look! Since this is in shared/, is only a rename, and the try run is green, going to go with r=me.
Attachment #8617079 - Flags: review+
(Assignee)

Comment 10

3 years ago
In master: https://github.com/mozilla-b2g/gaia/commit/e3eaf72ccd1bfe6d60d37efde6d3b92c1dbc5ff9
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.