Closed Bug 1172537 Opened 5 years ago Closed 5 years ago

Make the warning: "Tiled PaintedLayer with no scrollable container ancestor" occur only on actual b2g phones

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: paul, Assigned: paul)

References

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

B2G on Desktop, the terminal is spammed with:
[Child 6159] WARNING: Tiled PaintedLayer with no scrollable container ancestor: file /Users/paul/mozilla/src/gfx/layers/client/ClientTiledPaintedLayer.cpp, line 150

It happens when scrolling. Around ~20 warning per scroll.

What does this warning mean? Is it bad? Are we taking a slow path?

The setup:
- B2G desktop (osx). Multi-process enabled. Debug build
- app in an iframe
- app itself includes several remote mozbrowser iframes (it's a browser)
- apzc disabled
This shouldn't matter.

The comment above the warning suggests that android/b2g are guaranteed to have a displayport set, which isn't true if apzc is disabled.
Whiteboard: gfx-noted
Nical, can you please confirm that this warning is ok? Thanks!
Flags: needinfo?(nical.bugzilla)
(In reply to Matt Woodrow (:mattwoodrow) from comment #1)
> This shouldn't matter.
> 
> The comment above the warning suggests that android/b2g are guaranteed to
> have a displayport set, which isn't true if apzc is disabled.

So we end up in an unexpected code path?
We are trying to enable apzc on B2G on osx, but in the meantime, should we disable tiles?
(In reply to Mason Chang [:mchang] from comment #2)
> Nical, can you please confirm that this warning is ok? Thanks!

Yeah, shouldn't be a problem. On b2g we only use tiled layers for scrollable content in order to save memory. On mac we use tiled layers for all painted content scrollable or not. It's a tradeoff because non-tiled painted layers are synchronous, so we trade memory consumption for better scheduling/performance.

b2g desktop is a bit of a Frankenstein configuration and it looks like it uses mac's tiling strategy with this warning that is meant for b2g on actual phones.

No need to disable tiles, we should either make sure the warning is only on actual b2g phones (or have b2g desktop use the same tiling strategy as real-b2g).
Flags: needinfo?(nical.bugzilla)
Summary: what is causing this warning: "Tiled PaintedLayer with no scrollable container ancestor" → Make the warning: "Tiled PaintedLayer with no scrollable container ancestor" occur only on actual b2g phones
Attached patch v1Splinter Review
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #8617724 - Flags: review?(nical.bugzilla)
Attachment #8617724 - Flags: review?(nical.bugzilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b9702891ab15
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Blocks: graphene
You need to log in before you can comment on or make changes to this bug.