117256 - Timer core dump on shutdown

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[Suresh Duddi (gone)]

I see this core dump on shutdown. Looks like the timer thread has been shutdown
by now and when we go killing services, they wanna shutdown their timers.

TimerThread::RemoveTimer(nsTimerImpl * 0x04240b90) line 227 + 3 bytes
nsTimerImpl::Cancel(nsTimerImpl * const 0x04240b90) line 183
nsGlobalHistory::~nsGlobalHistory() line 544
nsGlobalHistory::`scalar deleting destructor'(unsigned int 1) + 15 bytes
nsGlobalHistory::Release(nsGlobalHistory * const 0x03f69170) line 564 + 154 bytes
nsCOMPtr_base::assign_assuming_AddRef(nsISupports * 0x00000000) line 436
nsCOMPtr_base::assign_with_AddRef(nsISupports * 0x00000000) line 74
nsCOMPtr<nsISupports>::operator=(nsISupports * 0x00000000) line 821
FreeServiceFactoryEntryEnumerate(PLDHashTable * 0x00486844, PLDHashEntryHdr *
0x003bc318, unsigned int 402, void * 0x00000000) line 1689
PL_DHashTableEnumerate(PLDHashTable * 0x00486844, int (PLDHashTable *,
PLDHashEntryHdr *, unsigned int, void *)* 0x100743d0
FreeServiceFactoryEntryEnumerate(PLDHashTable *, PLDHashEntryHdr *, unsigned
int, void *), void * 0x00000000) line 601 + 34 bytes
nsComponentManagerImpl::FreeServices() line 1714 + 19 bytes
NS_ShutdownXPCOM(nsIServiceManager * 0x00000000) line 558
main(int 1, char * * 0x00484560) line 1602 + 8 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77e992a6()

Comment 1

[Suresh Duddi (gone)]

Attachment: Protect against timer thread vanishing as it happens on shutdown

Comment 2

[Suresh Duddi (gone)]

Anyone around for a review.

Comment 3

[Cathleen]

Comment on attachment 62956 [details] [diff] [review]
Protect against timer thread vanishing as it happens on shutdown

r=cathleen

Comment 4

[Suresh Duddi (gone)]

So I checked this in. Pav/Dougt we can revert/change if you guys think otherwise.