1172601 - HTML5 video full-screen mode hides OS X menu bar, but shows desktop instead of going full-screen

Status: RESOLVED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Watch any YouTube or Vimeo video on OS X.
2. Click the video's full-screen button.

RESULT:
Firefox's menu bar disappears and the video fills the full browser window area, but Firefox reveals the OS X desktop where the menu bar was instead of taking the video full-screen.

This bug appears to be a regression from OS X bug 1105939.

Comment 1

[Chris Peterson [:cpeterson]]

Regression pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=360ebcf8f058&tochange=00ffe2b5199f

Comment 2

[Markus Stange [:mstange]]

I see this too. I'm on 10.10(.4).

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

I cannot reproduce this on 10.9. If you are both using 10.10, probably the traditional fullscreen stuff has some problem with 10.10. I don't have 10.10 installed at present, unfortunately.

:mstange, :smichaud, could one of you help look into this problem, please?

Comment 4

[Chris Peterson [:cpeterson]]

I amusing 10.10.3 (14D136).

Comment 5

[Steven Michaud [:smichaud] (Retired)]

I just tested with videos on www.vimeo.com and today's m-c nightly on all the major versions of OS X we support (from 10.6.8 up).  I do see this bug on OS X 10.10.3, but not on any other versions of OS X.  I tested with e10s on and off.

The odd thing is that, while reviewing Xidorn's patch, I did test on OS X 10.10.3 and *didn't* notice this bug.  I'm not sure why -- especially I still have my latest test build, and that *does* show the bug.

The first thing that springs to mind is that maybe we shouldn't have completely backed out the patch for bug 740923.

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

(In reply to Steven Michaud [:smichaud] from comment #5)
> The first thing that springs to mind is that maybe we shouldn't have
> completely backed out the patch for bug 740923.

I don't think it's related to the backout of bug 740923. This bug sounds like the window is put into fullscreen before the menubar completely hidden.

I just submit a new patch to replace the SetSystemUIMode call with [NSApplication setPresentationOptions:] in bug 1172664. I wonder whether that could fix this bug. Could you test that?

Comment 7

[Steven Michaud [:smichaud] (Retired)]

That's really just a guess ... but I'll test it.

By the way, I think it's best to make a habit of posting tryserver builds for new patches you want people to test.

And you really should set yourself up to be able to boot into all the major versions of OS X that we support, from OS X 10.6.8 up.  To run the older ones, you may need to get an older machine from Mozilla.

Mozilla has been distributing MacBook Pros to staff members for some time, and some of them get returned when they're superceded.  For example I have an old MacBookPro8,2 which can run everything from 10.6.X to 10.10.X.  I have spare partitions on each of my machines, each 30GB to 40GB.  40GB is enough for the OS and a full development environment.

Comment 8

[Steven Michaud [:smichaud] (Retired)]

> I have spare partitions on each of my machines, each 30GB to 40GB.

I have 3-4 spare partitions on each of my machines.

Comment 9

[Steven Michaud [:smichaud] (Retired)]

From the results of tests by Markus and me, it looks like the patch for bug 1172664 really does fix this bug.  Bug 1172664 has now been r+ed and should land soon.

Comment 11

[(no longer active)]

Yes, bug 1172664 seems to have fixed this for me too.

Comment 14

[Xidorn Quan [:xidorn] UTC+11]

As most feedback yet seems to support that this bug has been fixed, mark it as WORKSFORME.

Comment 16

[Aaron]

I'm having this problem with Firefox Quantum 57.0, except the desktop shows where the dock usually is instead of the menu bar as mentioned before.

It only happens when firefox is not running in fullscreen and you try to watch a fullscreen video - if firefox is running in fullscreen then a fullscreen video will use the entire screen.

Comment 17

[Aaron]

(In reply to Aaron from comment #16)
> I'm having this problem with Firefox Quantum 57.0, except the desktop shows
> where the dock usually is instead of the menu bar as mentioned before.
> 
> It only happens when firefox is not running in fullscreen and you try to
> watch a fullscreen video - if firefox is running in fullscreen then a
> fullscreen video will use the entire screen.

FYI: I am running MacOS 10.13 High Sierra