Closed
Bug 1172627
Opened 9 years ago
Closed 8 years ago
test_instance_re-parent.html is going to permafail when Gecko 40 merges to Beta.
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox39 fixed, firefox40 disabled, firefox41 disabled, firefox42 disabled, firefox43 affected, firefox-esr38 fixed)
People
(Reporter: RyanVM, Assigned: bugzilla)
References
Details
Attachments
(2 files)
3.80 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
4.59 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]: Permafail when Gecko 40 merges to Beta. Aaron, any idea what's going on here? https://treeherder.mozilla.org/logviewer.html#?job_id=8236329&repo=try 21:21:05 INFO - 2554 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_instance_re-parent.html | Testing for exception getting instance count from plugin. - got true, expected false 21:21:05 INFO - 2555 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_instance_re-parent.html | uncaught exception - TypeError: p.stopWatchingInstanceCount is not a function at http://mochi.test:8888/tests/dom/plugins/test/mochitest/test_instance_re-parent.html:86 21:21:05 INFO - JavaScript error: http://mochi.test:8888/tests/dom/plugins/test/mochitest/test_instance_re-parent.html, line 86: TypeError: p.stopWatchingInstanceCount is not a function
Flags: needinfo?(aklotz)
Assignee | ||
Comment 1•9 years ago
|
||
Probably more fallout from bug 1158761. I'll look into it.
Flags: needinfo?(aklotz)
Assignee | ||
Comment 2•9 years ago
|
||
Post bug 1158761 it's no longer guaranteed that a plugin instance will be stopped within one event loop iteration. I think that's what we were seeing here. This patch updates the test to try again a few times, just like the other tests that were updated in bug 1158761.
Updated•9 years ago
|
Attachment #8617050 -
Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/2a981c61aa56
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Reporter | ||
Updated•9 years ago
|
status-firefox40:
--- → affected
Flags: needinfo?(ryanvm)
Reporter | ||
Comment 5•9 years ago
|
||
Marking the dep on bug 1158761 in the event that we successfully uplift it to Beta39 at some point.
Assignee | ||
Comment 7•9 years ago
|
||
It's testonly so according to tree rules I don't need approval to land. https://hg.mozilla.org/releases/mozilla-aurora/rev/b2717492637e
Reporter | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-esr38/rev/9f8bc5db8448
Flags: in-testsuite+
Assignee | ||
Updated•9 years ago
|
status-firefox39:
--- → affected
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/e9bcd88c25ce
Reporter | ||
Comment 10•9 years ago
|
||
This is still happening on Try push off Aurora tip from a couple days ago. https://treeherder.mozilla.org/logviewer.html#?job_id=8744443&repo=try
Status: RESOLVED → REOPENED
Flags: needinfo?(aklotz)
Resolution: FIXED → ---
Target Milestone: mozilla41 → ---
Assignee | ||
Comment 11•9 years ago
|
||
I've been seeing bugmail for bug 976824 as well. Looks like we'll need to increase the retry threshold for the affected tests.
Assignee | ||
Comment 12•9 years ago
|
||
We essentially just need to wait longer for the plugin stop event to propagate.
Flags: needinfo?(aklotz)
Attachment #8625816 -
Flags: review?(jmathies)
Updated•9 years ago
|
Attachment #8625816 -
Flags: review?(jmathies) → review+
Comment 14•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e419080121a3
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Comment 15•9 years ago
|
||
Ryan, can you handle the a=testonly uplift, please?
Flags: needinfo?(ryanvm)
Reporter | ||
Comment 16•9 years ago
|
||
Whoops, I actually did already but forgot to mark the bug. Whoopsie.
Flags: needinfo?(ryanvm)
Reporter | ||
Comment 17•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/82bba5c10f61
test_instance_re-parent.html disabled in https://hg.mozilla.org/releases/mozilla-beta/rev/f1bf17bff7c4 Hopefully that's the only one that needs it.
Flags: needinfo?(aklotz)
Reporter | ||
Updated•9 years ago
|
Status: RESOLVED → REOPENED
status-firefox42:
--- → affected
Resolution: FIXED → ---
Target Milestone: mozilla41 → ---
Assignee | ||
Comment 19•9 years ago
|
||
Should be. That one seems to be the trouble spot. I'll look at it some more.
Flags: needinfo?(aklotz)
Assignee | ||
Comment 20•9 years ago
|
||
Test disabled on beta so I'm clearing the tracking flag there.
tracking-firefox40:
+ → ---
Reporter | ||
Comment 21•9 years ago
|
||
Disabled again for Beta41. https://hg.mozilla.org/releases/mozilla-beta/rev/e60aa8081057 Aaron, let's just disable this across the board since there's clearly not much motivation to get it fixed.
status-firefox43:
--- → affected
Flags: needinfo?(aklotz)
Assignee | ||
Comment 22•9 years ago
|
||
I am working on it, can reproduce it in a VM. Trying to get this cleared up now.
Flags: needinfo?(aklotz)
Skipped for 42 also: https://hg.mozilla.org/releases/mozilla-beta/rev/8e75fa6f65b7
Switching this to skip-if = release_build so we don't have to keep doing this every release: https://hg.mozilla.org/mozilla-central/rev/f4ccde68eaf7 https://hg.mozilla.org/releases/mozilla-aurora/rev/8ccfd518beef https://hg.mozilla.org/releases/mozilla-beta/rev/e0d7cf7e7838
Flags: needinfo?(aklotz)
Assignee | ||
Comment 26•9 years ago
|
||
Thanks. This is still on my radar and I'll remove the skip-ifs as soon as I fix the tests.
Flags: needinfo?(aklotz)
Comment 27•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f4ccde68eaf7
status-b2g-v2.5:
--- → fixed
Comment 28•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
Reporter | ||
Comment 29•8 years ago
|
||
I think we should wontfix this. What do you think?
Flags: needinfo?(aklotz)
Reporter | ||
Updated•8 years ago
|
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
Resolution: --- → WONTFIX
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•