Probably more fallout from bug 1158761. I'll look into it.
Post bug 1158761 it's no longer guaranteed that a plugin instance will be stopped within one event loop iteration. I think that's what we were seeing here. This patch updates the test to try again a few times, just like the other tests that were updated in bug 1158761.
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Attachment #8617050 - Flags: review?(jmathies)
Marking the dep on bug 1158761 in the event that we successfully uplift it to Beta39 at some point.
It's testonly so according to tree rules I don't need approval to land. https://hg.mozilla.org/releases/mozilla-aurora/rev/b2717492637e
This is still happening on Try push off Aurora tip from a couple days ago. https://treeherder.mozilla.org/logviewer.html#?job_id=8744443&repo=try
I've been seeing bugmail for bug 976824 as well. Looks like we'll need to increase the retry threshold for the affected tests.
We essentially just need to wait longer for the plugin stop event to propagate.
Attachment #8625816 - Flags: review?(jmathies)
Ryan, can you handle the a=testonly uplift, please?
Whoops, I actually did already but forgot to mark the bug. Whoopsie.
test_instance_re-parent.html disabled in https://hg.mozilla.org/releases/mozilla-beta/rev/f1bf17bff7c4 Hopefully that's the only one that needs it.
Should be. That one seems to be the trouble spot. I'll look at it some more.
Disabled again for Beta41. https://hg.mozilla.org/releases/mozilla-beta/rev/e60aa8081057 Aaron, let's just disable this across the board since there's clearly not much motivation to get it fixed.
I am working on it, can reproduce it in a VM. Trying to get this cleared up now.
Skipped for 42 also: https://hg.mozilla.org/releases/mozilla-beta/rev/8e75fa6f65b7
Switching this to skip-if = release_build so we don't have to keep doing this every release: https://hg.mozilla.org/mozilla-central/rev/f4ccde68eaf7 https://hg.mozilla.org/releases/mozilla-aurora/rev/8ccfd518beef https://hg.mozilla.org/releases/mozilla-beta/rev/e0d7cf7e7838
Thanks. This is still on my radar and I'll remove the skip-ifs as soon as I fix the tests.
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
I think we should wontfix this. What do you think?
Status: REOPENED → RESOLVED
Closed: 4 years ago → 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.