1172627 - test_instance_re-parent.html is going to permafail when Gecko 40 merges to Beta.

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafail when Gecko 40 merges to Beta.

Aaron, any idea what's going on here?

https://treeherder.mozilla.org/logviewer.html#?job_id=8236329&repo=try

21:21:05 INFO - 2554 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_instance_re-parent.html | Testing for exception getting instance count from plugin. - got true, expected false
21:21:05 INFO - 2555 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_instance_re-parent.html | uncaught exception - TypeError: p.stopWatchingInstanceCount is not a function at http://mochi.test:8888/tests/dom/plugins/test/mochitest/test_instance_re-parent.html:86
21:21:05 INFO - JavaScript error: http://mochi.test:8888/tests/dom/plugins/test/mochitest/test_instance_re-parent.html, line 86: TypeError: p.stopWatchingInstanceCount is not a function

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Probably more fallout from bug 1158761. I'll look into it.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Update test

Post bug 1158761 it's no longer guaranteed that a plugin instance will be stopped within one event loop iteration. I think that's what we were seeing here. This patch updates the test to try again a few times, just like the other tests that were updated in bug 1158761.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2a981c61aa56

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2a981c61aa56

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Marking the dep on bug 1158761 in the event that we successfully uplift it to Beta39 at some point.

Comment 6

[jen strickland :jenstrickland]

Tracking enabled for 40 to verify that a fix makes it in.

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

It's testonly so according to tree rules I don't need approval to land.
https://hg.mozilla.org/releases/mozilla-aurora/rev/b2717492637e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr38/rev/9f8bc5db8448

Comment 9

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/releases/mozilla-beta/rev/e9bcd88c25ce

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This is still happening on Try push off Aurora tip from a couple days ago.
https://treeherder.mozilla.org/logviewer.html#?job_id=8744443&repo=try

Comment 11

[(No longer employed by Mozilla) Aaron Klotz]

I've been seeing bugmail for bug 976824 as well. Looks like we'll need to increase the retry threshold for the affected tests.

Comment 12

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Increase thresholds

We essentially just need to wait longer for the plugin stop event to propagate.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e419080121a3

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e419080121a3

Comment 15

[(No longer employed by Mozilla) Aaron Klotz]

Ryan, can you handle the a=testonly uplift, please?

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Whoops, I actually did already but forgot to mark the bug. Whoopsie.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/82bba5c10f61

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

test_instance_re-parent.html disabled in https://hg.mozilla.org/releases/mozilla-beta/rev/f1bf17bff7c4

Hopefully that's the only one that needs it.

Comment 19

[(No longer employed by Mozilla) Aaron Klotz]

Should be. That one seems to be the trouble spot. I'll look at it some more.

Comment 20

[(No longer employed by Mozilla) Aaron Klotz]

Test disabled on beta so I'm clearing the tracking flag there.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Disabled again for Beta41.

https://hg.mozilla.org/releases/mozilla-beta/rev/e60aa8081057

Aaron, let's just disable this across the board since there's clearly not much motivation to get it fixed.

Comment 22

[(No longer employed by Mozilla) Aaron Klotz]

I am working on it, can reproduce it in a VM. Trying to get this cleared up now.

Comment 23

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Skipped for 42 also: https://hg.mozilla.org/releases/mozilla-beta/rev/8e75fa6f65b7

Comment 24

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/f4ccde68eaf7

Comment 25

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Switching this to skip-if = release_build so we don't have to keep doing this every release:
https://hg.mozilla.org/mozilla-central/rev/f4ccde68eaf7
https://hg.mozilla.org/releases/mozilla-aurora/rev/8ccfd518beef
https://hg.mozilla.org/releases/mozilla-beta/rev/e0d7cf7e7838

Comment 26

[(No longer employed by Mozilla) Aaron Klotz]

Thanks. This is still on my radar and I'll remove the skip-ifs as soon as I fix the tests.

Comment 27

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f4ccde68eaf7

Comment 28

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 29

[Ryan VanderMeulen [:RyanVM]]

I think we should wontfix this. What do you think?

Comment 30

[(No longer employed by Mozilla) Aaron Klotz]

Sure.