1172629 - test_cache_restart.html is going to permafail when Gecko 41 merges to Beta

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer.html#?job_id=8235803&repo=try

21:14:10 INFO - 1699 INFO TEST-START | dom/cache/test/mochitest/test_cache_restart.html
21:14:10 INFO - ###!!! [Parent][OnMaybeDequeueOne] Error: Channel closing: too late to send/recv, messages will be lost
21:14:11 INFO - 1700 INFO TEST-UNEXPECTED-FAIL | dom/cache/test/mochitest/test_cache_restart.html | uncaught exception - ReferenceError: caches is not defined at http://mochi.test:8888/tests/dom/cache/test/mochitest/test_cache_restart.html:35
21:14:11 INFO - JavaScript error: http://mochi.test:8888/tests/dom/cache/test/mochitest/test_cache_restart.html, line 35: ReferenceError: caches is not defined
21:14:11 INFO - MEMORY STAT vsize after test: 21991997509632
21:14:11 INFO - MEMORY STAT residentFast after test: 1092706304
21:14:11 INFO - 1701 INFO TEST-OK | dom/cache/test/mochitest/test_cache_restart.html | took 286ms
21:14:11 INFO - 1702 INFO TEST-START | dom/cache/test/mochitest/test_cache_shrink.html
21:14:14 INFO - JavaScript error: http://mochi.test:8888/tests/dom/cache/test/mochitest/test_cache_shrink.html, line 80: ReferenceError: caches is not defined
21:19:16 INFO - Xlib: extension "RANDR" missing on display ":0".
21:19:16 INFO - TEST-INFO | screentopng: exit 0
21:19:16 INFO - 1703 INFO TEST-PASS | dom/cache/test/mochitest/test_cache_shrink.html | disk usage should be zero to start
21:19:16 INFO - 1704 INFO TEST-UNEXPECTED-FAIL | dom/cache/test/mochitest/test_cache_shrink.html | Test timed out. - expected PASS
21:19:16 INFO - MEMORY STAT vsize after test: 21991876059136
21:19:16 INFO - MEMORY STAT residentFast after test: 1108299776
21:19:16 INFO - 1705 INFO TEST-OK | dom/cache/test/mochitest/test_cache_shrink.html | took 305766ms

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Ugh.  The test sets the right pref, but its too late to unhide the .caches getter on the window global.  The window global is already setup by the time the script runs.  I think we have to use an iframe for this test and test_cache_shrink.html.

Ehsan, is there any other easier way?

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Actually, can we just disable these tests for beta and release?  I'm hoping to remove this pref completely in the few weeks, so I don't really feel like re-writing these tests just to set it properly.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Skip Cache restart and shrink tests if dom.caches.enabled is not set. r=ehsan

This skips the test if the pref is disabled.  Like I said above, I think this makes more sense since the pref will be removed in the near future.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8617005 [details] [diff] [review]
Skip Cache restart and shrink tests if dom.caches.enabled is not set.  r=ehsan

Review of attachment 8617005 [details] [diff] [review]:
-----------------------------------------------------------------

Note.  There are no changes in the big test blocks.  I just had to do an indentation change since I can't return from the outer most level of a script tag.

Comment 5

[(no longer active)]

Fixing this "properly" isn't actually very difficult, all you really need is to access the caches property from a global created after setting the pref.  A very simple trick for doing that is using an empty iframe.  I have a patch that does this alternative.  How about this?

Comment 6

[(no longer active)]

Attachment: Use the caches global property from an iframe loaded after setting the pref in order to make the tests pass with the pref disabled

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8617334 [details] [diff] [review]
Use the caches global property from an iframe loaded after setting the pref in order to make the tests pass with the pref disabled

Review of attachment 8617334 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  That probably would have taken me a few hours to figure out.

Comment 8

[(no longer active)]

np :)

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72c67850a705

Comment 10

[(no longer active)]

Ryan, do you mind backporting this to Aurora please?  Thanks!

Comment 11

[Ben Kelly [:bkelly, not reviewing]]

Ehsan fixed this. :-)

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/72c67850a705

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Unless I'm missing something here, these tests were added by bug 1165395, which landed for Gecko 41.

Comment 14

[(no longer active)]

Yes, you're right!